Page MenuHomePhabricator

elm_list: return from sizing_eval immediately if called during constructor
ClosedPublic

Authored by zmike on Jun 18 2018, 1:00 PM.

Details

Summary

this is both invalid and useless, so return immediately before spending cpu
time and generating error messages

fix T7035

Depends on D6324

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jun 18 2018, 1:00 PM
zmike requested review of this revision.Jun 18 2018, 1:00 PM

I somehow don't like those silent returns. We fix a null access by disabling another null access silently. Thats ... weird.

What do you think about:

if (!efl_finalized_get(obj)) return;

This would be IMO a lot better, as the finalized bit is a way more defined thing than the box field. As thats a implementation detail that is not defined to be there at this point ... :)

bu5hm4n requested changes to this revision.Jun 19 2018, 10:07 AM
This revision now requires changes to proceed.Jun 19 2018, 10:07 AM

Seems good, will change.

zmike updated this revision to Diff 15046.Jun 19 2018, 10:15 AM
zmike edited the summary of this revision. (Show Details)
bu5hm4n accepted this revision.Jun 19 2018, 10:21 AM
This revision is now accepted and ready to land.Jun 19 2018, 10:21 AM
This revision was automatically updated to reflect the committed changes.