Page MenuHomePhabricator
Differential D6326

edje: Demote 'No such part...' from WRN to DBG
AbandonedPublic
Actions

Authored by segfaultxavi on Jun 19 2018, 2:35 AM.

Details

Reviewers
zmike
bu5hm4n
devilhorns
Summary

Tons of these are intended, so having them as warnings seems way too noisy
to me.

Test Plan

elementary_test can now be run with EINA_LOG_LEVEL=2 in a much friendlier manner.

Diff Detail

Repository
rEFL core/efl
Branch
devs/xartigas/demote-warning
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6509
Build 6742: arc lint + arc unit
segfaultxavi created this revision.Jun 19 2018, 2:35 AM
segfaultxavi requested review of this revision.Jun 19 2018, 2:35 AM
zmike requested changes to this revision.Jun 19 2018, 7:21 AM

I don't think this is right. In some cases it may be that a theme doesn't implement the requested part, but in other cases (which are definite bug cases) the user may have just mistyped the part name or something.

This revision now requires changes to proceed.Jun 19 2018, 7:21 AM
segfaultxavi added a comment.Jun 19 2018, 7:32 AM
In D6326#108205, @zmike wrote:

I don't think this is right. In some cases it may be that a theme doesn't implement the requested part, but in other cases (which are definite bug cases) the user may have just mistyped the part name or something.

Agreed, but the true errors will be hidden by the myriad of false, intended, warnings. Surely something needs to be done!

zmike added a comment.Jun 19 2018, 7:33 AM

See T7030 and T6326. These are errors which should be fixed.

segfaultxavi abandoned this revision.Jul 9 2018, 3:40 AM

Revision Contents
Changeset List

PathPackages
Msrc/lib/edje/edje_part_invalid.c (2 lines)

Diff 15032

View Options

src/lib/edje/edje_part_invalid.c

Loading...