Page MenuHomePhabricator

allow only one instance of the controls frame
AbandonedPublic

Authored by billiob on Jun 21 2018, 8:12 PM.

Details

Reviewers
camthesaxman_
Group Reviewers
Terminology

Diff Detail

Repository
rTRM apps/terminology
Branch
fix_contol_slide
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6559
Build 6753: arc lint + arc unit
camthesaxman_ requested review of this revision.Jun 21 2018, 8:12 PM
camthesaxman_ created this revision.

Could you please explain why you want that change?

There is a bug in which closing and re-opening the controls frame before the animation finishes leaves the old one on the screen. Clicking controls on these stale frames crashes Terminology. There is absolutely no reason to have multiple instances of the controls frame open at once. Making it a singleton fixes this bug and simplifies the code.
https://streamable.com/641gc

Thank you for the patch.
I took an other direction to fix the issue. See 1c4482115b11786ac6a1db6f97ec256ff4ca9886. This way there can still be different controls on different windows (when there's only one process).

billiob commandeered this revision.Jul 19 2018, 10:15 AM
billiob abandoned this revision.
billiob added a reviewer: camthesaxman_.