Page MenuHomePhabricator

Focus Manager: Recursively go into subobjects. This fixes scrollabe popup being broken @T6886
AbandonedPublic

Authored by stephenmhouston on Jun 21 2018, 10:35 PM.

Details

Summary

Bisected to commit 253430ab76348d99c81e3b753b6a32817bdb6666 as the start of the problem. Changed Focus Manager back to recursively calcing subobjects.

Test Plan

Scrollable popup worked before this commit and did not after. Applying this patch allows it to work again.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6560
Build 6754: arc lint + arc unit
stephenmhouston requested review of this revision.Jun 21 2018, 10:35 PM

Upon further testing this only fixes the elm_test scrollable popup case and does not fix Ephoto's scrollable popup in settings.

bu5hm4n requested changes to this revision.Jun 22 2018, 12:42 AM

Whatever the reason is for this is, its wrong. we have to call _next here, as otherwise we dont explore the full tree but skip most of the nodes in the tree.

Also, how is this supposed to change anything in regards of placing and rendering ?

This revision now requires changes to proceed.Jun 22 2018, 12:42 AM
zmike added a comment.Jun 22 2018, 6:39 AM

After a PM from @stephenmhouston, this patch is not intended to "fix" the issue, it's an attempt to provide more info since he's going afk for a period of time. Perhaps this is in some way helpful to you?

Okay, i wasn't aware of that, i thought you want to have that in master ... :)

Sorry, I am sometimes a bit of a hothead :)

stephenmhouston abandoned this revision.Jul 5 2018, 2:43 PM