Page MenuHomePhabricator

Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206

Authored by vtorri on Jun 22 2018, 12:05 AM.


  • add missing types
  • remove deprecated functions (which have a gcc extension)
Test Plan

compilation with vc++

Diff Detail

rEFL core/efl
No Linters Available
No Unit Test Coverage
Build Status
Buildable 6562
Build 6756: arc lint + arc unit
vtorri created this revision.Jun 22 2018, 12:05 AM
vtorri requested review of this revision.Jun 22 2018, 12:05 AM
zmike requested changes to this revision.Jun 22 2018, 6:37 AM

Even if the function is deprecated it cannot be removed until 2.0. You can replace the implementation with the gcc extension I guess?

This revision now requires changes to proceed.Jun 22 2018, 6:37 AM

i've already broken the API on Windows several times. These functions are not used anymore and should not be used, even internally.

zmike added a comment.Jun 22 2018, 7:08 AM

Okay, but let's avoid breaking ABI at least, since there are automated tools that are run on EFL which will produce errors for cases like this. I'm fine if you really want to remove the prototype in the header (though imo leaving it deprecated is also fine), but at least leave the symbol with a NULL return as its implementation to avoid ABI compliance checker errors.

vtorri abandoned this revision.Jun 29 2018, 1:00 AM

i used wrongly arcanist locally, so i created another patch, see D6478
closing this one