Page MenuHomePhabricator
Differential D6368

evas/cpu: rework SIGILL code for non-x86 (and fix windows build)
ClosedPublic
Actions

Authored by zmike on Jun 22 2018, 10:38 AM.

Details

Reviewers
ManMower
devilhorns
vtorri
Maniphest Tasks
T7062: windows build broken: evas_cpu.c errors
Commits
rEFLb60a9999ca76: evas/cpu: rework SIGILL code for non-x86 (and fix windows build)
Summary

the previous patch which improved this code for x86 archs broke compiling
for non-x86 and, coincidentally, for windows builds on x86 due to some
unusual #ifdef blocks

this attempts to restore handling on non-x86 and adds additional #ifdefs for
functions which did not build on windows due to removed code

ref 6b1ab3cd9c7e19908690e9e913df7504cc8ae7c8

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jun 22 2018, 10:38 AM
zmike requested review of this revision.Jun 22 2018, 10:38 AM
ManMower accepted this revision.Jun 22 2018, 10:53 AM

Ouch! Thanks for fixing my mess on this one.

This revision is now accepted and ready to land.Jun 22 2018, 10:53 AM
zmike updated this revision to Diff 15146.Jun 22 2018, 11:09 AM

resolve some linux x86 compiler warnings

zmike requested review of this revision.Jun 22 2018, 11:09 AM
ManMower accepted this revision.Jun 22 2018, 11:17 AM
This revision is now accepted and ready to land.Jun 22 2018, 11:17 AM
vtorri accepted this revision.Jun 22 2018, 12:36 PM
Closed by commit rEFLb60a9999ca76: evas/cpu: rework SIGILL code for non-x86 (and fix windows build) (authored by zmike). · Explain WhyJun 22 2018, 12:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/evas/common/evas_cpu.c (30 lines)

Diff 15149

View Options

src/lib/evas/common/evas_cpu.c

Loading...