Page MenuHomePhabricator

ecore/glib: add #ifdef guards for newly added includes
ClosedPublic

Authored by zmike on Jun 22 2018, 10:48 AM.

Details

Summary

these headers are not available on all platforms (e.g., windows) and so
the corresponding #ifdef checks must be used in order to correctly include
them

ref 1adb73cef82c45f2cc8766f43ffb88288e7e8a65
ref T5725
fix T7063

Depends on D6368

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jun 22 2018, 10:48 AM
zmike requested review of this revision.Jun 22 2018, 10:48 AM
ManMower accepted this revision.Jun 22 2018, 11:00 AM
ManMower added a subscriber: ManMower.

Yup, this is consistent with similar usage elsewhere in EFL

This revision is now accepted and ready to land.Jun 22 2018, 11:00 AM

i would have done :

#ifdef _WIN32
# include <ws2tcpip.h>
#endif
#ifdef HAVE_NETDB_H
# include <netdb.h>
#endif

In that case there are other places in EFL which should be changed to match...

zmike updated this revision to Diff 15148.Jun 22 2018, 12:26 PM
zmike edited the summary of this revision. (Show Details)

update guards

vtorri accepted this revision.Jun 22 2018, 12:38 PM
This revision was automatically updated to reflect the committed changes.