ecore/thread: flush main loop threads during ecore_thread_wait()
ClosedPublic
Actions

This looks a little silly now with potentially frequent back to back ecore_time_get() calls, but seems functionally correct. If anyone cares that could be a follow up clean up.

Is a 1/10th of a ms timeout too aggressive? Anyway, solves a potential deadlock condition, accepted.

This revision is now accepted and ready to land.Jun 27 2018, 8:51 AM

Closed by commit rEFLb45561750039: ecore/thread: flush main loop threads during ecore_thread_wait() (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJun 28 2018, 9:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/ecore/ecore_thread.c (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15298	bb41724		Jun 26 2018, 3:31 PM	★	★
Diff 2	15354	04d209e	rEFLb45561750039792a8d8c8def76f1bdc4812b962f	Jun 28 2018, 9:08 AM	★	★

Status	Author	Revision
Closed	zmike	D6449 eio/fallback: avoid emitting monitor events if the backend is pending deletion
Closed	zmike	D6448 tests: check eio monitors for fallback monitoring
Closed	zmike	D6447 eio: add method for determining if a monitor is using the fallback mechanism
Closed	zmike	D6446 tests: cancel the timeout timer when cleaning up eio tests
Closed	zmike	D6445 tests: increase eio monitor+sentry test initial delay to 0.05s
Closed	zmike	D6444 eio/fallback: do not modify the children hash while iterating it
Closed	zmike	D6443 eio/fallback: mark all fallback monitors as fallbacks, not just for win32
Closed	zmike	D6442 eio/fallback: fix MODIFY event emission on base path when monitoring
Closed	zmike	D6441 eio/fallback: remove intermediate idler
Closed	zmike	D6440 eio/fallback: fix fallback shutdown when threads exist
Closed	zmike	D6439 eio/fallback: always create timer hash on fallback init
Closed	zmike	D6438 ecore/thread: flush main loop threads during ecore_thread_wait()
Closed	zmike	D6437 ecore/thread: flush main loop threads while waiting during shutdown
Closed	zmike	D6436 ecore/thread: increase loop iterations when waiting during shutdown
Closed	zmike	D6435 eina/mempool: remove debug thread check to verify mempool deletion thread
Closed	zmike	D6434 tests: ignore ibus module in ecore-imf tests when DISPLAY is not set
Closed	zmike	D6433 tests: avoid cascading failure in ecore-imf tests when not forking

Diff 15354

View Options

src/lib/ecore/ecore_thread.c

ecore/thread: flush main loop threads during ecore_thread_wait()ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 15354

src/lib/ecore/ecore_thread.c

ecore/thread: flush main loop threads during ecore_thread_wait()
ClosedPublic
Actions

Revision Contents
Changeset List