eio/fallback: remove intermediate idler
ClosedPublic
Actions

Authored by zmike on Jun 26 2018, 3:31 PM.

Details

Reviewers

ManMower
bu5hm4n
devilhorns

Commits

rEFL062f6cabdd0c: eio/fallback: remove intermediate idler

Summary

for some reason, the fallback thread would exit -> create timer ->
create idler -> create thread; the existence of the idler makes little
sense and introduces variability in the timer interval

@fix
Depends on D6440

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Jun 26 2018, 3:31 PM

Herald added a project: efl. · View Herald TranscriptJun 26 2018, 3:31 PM

Herald added subscribers: committers, cedric. · View Herald Transcript

zmike requested review of this revision.Jun 26 2018, 3:31 PM

Herald added a reviewer: devilhorns. · View Herald TranscriptJun 26 2018, 3:31 PM

zmike added a child revision: D6442: eio/fallback: fix MODIFY event emission on base path when monitoring.Jun 26 2018, 3:31 PM

Weird, I can't come up with a reason to use an idler.

This revision is now accepted and ready to land.Jun 27 2018, 9:38 AM

Closed by commit rEFL062f6cabdd0c: eio/fallback: remove intermediate idler (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJun 28 2018, 9:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/eio/eio_monitor_poll.c (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15301	273045a		Jun 26 2018, 3:31 PM	★	★
Diff 2	15357	1b18a4e	rEFL062f6cabdd0cb7ca96de92cbd149f7a23af7d9b7	Jun 28 2018, 9:08 AM	★	★

Status	Author	Revision
Closed	zmike	D6449 eio/fallback: avoid emitting monitor events if the backend is pending deletion
Closed	zmike	D6448 tests: check eio monitors for fallback monitoring
Closed	zmike	D6447 eio: add method for determining if a monitor is using the fallback mechanism
Closed	zmike	D6446 tests: cancel the timeout timer when cleaning up eio tests
Closed	zmike	D6445 tests: increase eio monitor+sentry test initial delay to 0.05s
Closed	zmike	D6444 eio/fallback: do not modify the children hash while iterating it
Closed	zmike	D6443 eio/fallback: mark all fallback monitors as fallbacks, not just for win32
Closed	zmike	D6442 eio/fallback: fix MODIFY event emission on base path when monitoring
Closed	zmike	D6441 eio/fallback: remove intermediate idler
Closed	zmike	D6440 eio/fallback: fix fallback shutdown when threads exist
Closed	zmike	D6439 eio/fallback: always create timer hash on fallback init
Closed	zmike	D6438 ecore/thread: flush main loop threads during ecore_thread_wait()
Closed	zmike	D6437 ecore/thread: flush main loop threads while waiting during shutdown
Closed	zmike	D6436 ecore/thread: increase loop iterations when waiting during shutdown
Closed	zmike	D6435 eina/mempool: remove debug thread check to verify mempool deletion thread
Closed	zmike	D6434 tests: ignore ibus module in ecore-imf tests when DISPLAY is not set
Closed	zmike	D6433 tests: avoid cascading failure in ecore-imf tests when not forking

Diff 15357

View Options

src/lib/eio/eio_monitor_poll.c