Page MenuHomePhabricator

elm/genlist: remove conditional in _calc_job for verifying show_item code
ClosedPublic

Authored by zmike on Jun 27 2018, 1:58 PM.

Details

Summary

I think at some point in the past this was necessary to avoid weird show
mechanics, but now things have changed and it's best to always attempt to
scroll and let the scroller internals figure things out

this resolves the case where attempting to scroll to an item during a genlist's
calc (ie. the item was not present in a full layout calc) would fail to scroll
to the item if the scroll method was TOP and the item was too close to the
bottom of the list

fix T6368
@fix

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jun 27 2018, 1:58 PM
zmike requested review of this revision.Jun 27 2018, 1:58 PM
Hermet added a subscriber: Hermet.

@SanghyeonLee could you please review this patch?

bu5hm4n accepted this revision.Aug 2 2018, 4:15 AM

I tested this now for multiple days, i cannot see what it could break, ephoto seems normal, elm_tests are looking normal.

This revision is now accepted and ready to land.Aug 2 2018, 4:15 AM
Closed by commit rEFL1a75537ab8cb: elm/genlist: remove conditional in _calc_job for verifying show_item code (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 2 2018, 4:29 AM
This revision was automatically updated to reflect the committed changes.