Page MenuHomePhabricator

ecore-con/legacy: kill server with DEL event if a dialer error occurs
ClosedPublic

Authored by zmike on Jun 29 2018, 8:20 AM.

Details

Summary

in the course of the efl-net rewrite, the previous relied-upon behavior
sequence of error -> disconnect -> del was broken, and error events no
longer triggered disconnects or server deletion.

the failure was caused by a check for the 'connecting' flag, preventing
DEL events from being triggered

further, the ordering of the events was flipped from ERROR -> DEL to
DEL -> ERROR; this is also fixed now

this caused any failed connection to leak the entire server connection
since existing handlers for the del event were never triggered and the
server was never destroyed

@fix
fix T6330

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6726
zmike created this revision.Jun 29 2018, 8:20 AM
zmike requested review of this revision.Jun 29 2018, 8:20 AM
devilhorns accepted this revision.Jul 3 2018, 9:41 AM
This revision is now accepted and ready to land.Jul 3 2018, 9:41 AM
This revision was automatically updated to reflect the committed changes.