Force immediate calculate on main_layout after sizing hints set.
@fix T6886
zmike | |
stephenmhouston | |
bu5hm4n | |
devilhorns |
committers |
Force immediate calculate on main_layout after sizing hints set.
@fix T6886
Elementary_test: popup -> select scrollable -> use popup examples.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Based on the surrounding code in that function, should there be an if (sd->main_layout) check before calling that?
This function can be expensive to call repeatedly...
If this works 100% of the time that's fine, but generally you wouldn't check calculating if you're just setting the recalc flag; that function was added specifically so that you could know whether to set the flag or manually call recalc because if you are inside a calc then you want to trigger the calc in order to avoid an infinite calc loop. I'd be concerned about such a loop for this case if there was an unstable edje object somewhere in the chain...
Just set flag to recalc. Don't check object is calculating.
Acting on comment from zmike.
I think probably if should be if (calculating) smart_calc(main_layout) else need_recalculate_set(main_layout) just to avoid potential infinite loops which might not occur with the default theme.