Page MenuHomePhabricator

efreet: simplify and fix efreetd launch
ClosedPublic

Authored by zmike on Jul 5 2018, 2:30 PM.

Details

Summary

this previously used an entire eina prefix to determine where to find
efreetd, when a simpler approach would have been to just pass the directory
where it's being installed

this also inhibited running the correct efreetd during in-tree builds and tests,
as it was using the install prefix instead of the in-tree wrapper script

@fix
fix T6713
Depends on D6515

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jul 5 2018, 2:30 PM
zmike requested review of this revision.Jul 5 2018, 2:30 PM
devilhorns added inline comments.Jul 5 2018, 8:13 PM
src/lib/efreet/efreet_cache.c
121

bs ?

devilhorns requested changes to this revision.Jul 5 2018, 8:15 PM
devilhorns added inline comments.
src/lib/efreet/efreet_cache.c
121

I don't see that function defined here, so this commit will not stand on its own unless that function is already existing....

This revision now requires changes to proceed.Jul 5 2018, 8:15 PM
bu5hm4n accepted this revision.Jul 5 2018, 11:21 PM
bu5hm4n added inline comments.
src/lib/efreet/efreet_cache.c
121

That part of the buildsystem static lib :) Which is linked in above :)

bu5hm4n requested changes to this revision.Jul 6 2018, 2:11 AM

Okay, it feels wrong, but i get a segfault in efreetd now ... WHAT ... investigating

bu5hm4n accepted this revision.Jul 6 2018, 6:35 AM

It was a old ecore module that was wrong.

This revision was not accepted when it landed; it landed in state Needs Revision.Jul 6 2018, 6:52 AM
Closed by commit rEFL36fc0ce77ee6: efreet: simplify and fix efreetd launch (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.