Differential D6522

ecore_wl2: Replace window ids with pointers
ClosedPublic
Actions

Authored by ManMower on Jul 6 2018, 7:02 AM.

Tags

Subscribers

cedric, committers, zmike

Details

Reviewers

Maniphest Tasks

T6222: e 22 beta freezing on Take Screenshot
T7053: Enlightenment internal windows break

Commits

rEFL78f27a3efff2: ecore_wl2: Replace window ids with pointers

Summary

There's no benefit to generating ids instead of just using the
Ecore_Wl2_Window pointer in events.

This has the added benefit of working around a really nasty hash collision
bug when multiple ecore_evas engines are used at once.

ref T7053
ref T6222

@beta_break
Depends on D6521

Diff Detail

Repository

Branch

amster

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 6781

ManMower created this revision.Jul 6 2018, 7:02 AM

Herald added a project: efl. · View Herald TranscriptJul 6 2018, 7:02 AM

Herald added subscribers: zmike, committers, cedric. · View Herald Transcript

ManMower requested review of this revision.Jul 6 2018, 7:02 AM

Herald added a reviewer: devilhorns. · View Herald TranscriptJul 6 2018, 7:02 AM

ManMower added a child revision: D6523: ecore_wl2: Remove ecore_wl2_display_window_find.Jul 6 2018, 7:02 AM

devilhorns accepted this revision.Jul 6 2018, 7:12 AM

This revision is now accepted and ready to land.Jul 6 2018, 7:12 AM

Closed by commit rEFL78f27a3efff2: ecore_wl2: Replace window ids with pointers (authored by ManMower, committed by devilhorns). · Explain WhyJul 6 2018, 7:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
~			src/lib/ecore_wl2/Ecore_Wl2.h (75 lines)
~			src/lib/ecore_wl2/ecore_wl2_display.c (17 lines)
~			src/lib/ecore_wl2/ecore_wl2_dnd.c (38 lines)
~			src/lib/ecore_wl2/ecore_wl2_input.c (122 lines)
~			src/lib/ecore_wl2/ecore_wl2_private.h (10 lines)
~			src/lib/ecore_wl2/ecore_wl2_surface.c (2 lines)
~			src/lib/ecore_wl2/ecore_wl2_window.c (55 lines)
~			src/lib/elementary/efl_selection_manager.c (12 lines)
~			src/lib/elementary/efl_ui_win.c (6 lines)
~			src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c (58 lines)
~			src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_private.h (2 lines)
~			src/modules/ecore_imf/wayland/wayland_imcontext.c (4 lines)

Diff 15495

src/lib/ecore_wl2/Ecore_Wl2.h

Loading...

src/lib/ecore_wl2/ecore_wl2_display.c

Loading...

src/lib/ecore_wl2/ecore_wl2_dnd.c

Loading...

src/lib/ecore_wl2/ecore_wl2_input.c

Loading...

src/lib/ecore_wl2/ecore_wl2_private.h

Loading...

src/lib/ecore_wl2/ecore_wl2_surface.c

Loading...

src/lib/ecore_wl2/ecore_wl2_window.c

Loading...

src/lib/elementary/efl_selection_manager.c

Loading...

src/lib/elementary/efl_ui_win.c

Loading...

src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c

Loading...

src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_private.h

Loading...

src/modules/ecore_imf/wayland/wayland_imcontext.c

Loading...