Page MenuHomePhabricator

tests/eina: make inclusion for define explicit and more compatible
ClosedPublic

Authored by zmike on Jul 9 2018, 4:48 AM.

Details

Summary

signal.h is not included with all build options somehow, making this
a bit unreliable. also check for define existence for random platforms
which don't define this symbol

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jul 9 2018, 4:48 AM
zmike requested review of this revision.Jul 9 2018, 4:48 AM
ManMower accepted this revision.Jul 9 2018, 9:53 AM
ManMower added a subscriber: ManMower.

I really don't like this, but can't really come up with anything better. :(

Feels like there should be a HAVE_SIGNAL_H or something instead. In case someone manages to sneak a #define SIGPROF for arches that don't already have it into one of our headers later or something.

This revision is now accepted and ready to land.Jul 9 2018, 9:53 AM
zmike added a comment.Jul 9 2018, 9:56 AM

For this specific case, the eina debug codepaths are all disabled on windows so there's no need to try running the tests there.

This revision was automatically updated to reflect the committed changes.