Page MenuHomePhabricator

tests/ecore: remove ecore-drm test
ClosedPublic

Authored by zmike on Jul 9 2018, 9:44 AM.

Details

Summary

this caused DSO linker issues when enabled and was only testing
init+shutdown for a deprecated component which has not been actively developed
in some time

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jul 9 2018, 9:44 AM
zmike requested review of this revision.Jul 9 2018, 9:44 AM
ManMower accepted this revision.Jul 9 2018, 9:49 AM
ManMower added a subscriber: ManMower.

wow. such coverage.

This revision is now accepted and ready to land.Jul 9 2018, 9:49 AM
devilhorns accepted this revision.Jul 9 2018, 9:54 AM
bu5hm4n requested changes to this revision.Jul 9 2018, 10:47 AM
bu5hm4n added a subscriber: bu5hm4n.

"wow. such coverage." with a test method (ecore_test_ecore_drm2) that is not called anywhere ?

This revision now requires changes to proceed.Jul 9 2018, 10:47 AM

was being sarcastic, as the only things these tests do anything to test are trivial refcounting bits copied from other efl sub-libraries.

Good point though - ecore_suite.c/.h changes appear to be missing

zmike requested review of this revision.Jul 9 2018, 11:04 AM

I didn't say I was fixing/enabling the tests. Currently these cause build failures if ecore-drm is enabled.

Okay, but, is there a prupose in keeping them ? initing them ten times and shutting them down 10 times does not sound usefull IMO

zmike added a comment.Jul 9 2018, 12:34 PM

Dunno, I figured a discussion about that could happen after the release. This was the smallest amount of change required to fix the build.

devilhorns accepted this revision.Jul 9 2018, 12:44 PM
zmike planned changes to this revision.Jul 10 2018, 6:54 AM

This is not a complete patch...

zmike updated this revision to Diff 15559.Jul 10 2018, 6:58 AM
zmike retitled this revision from tests/ecore: migrate ecore-drm tests to ecore-drm2 to tests/ecore: remove ecore-drm test.
zmike edited the summary of this revision. (Show Details)

remove test entirely

so is this complete now ?

Yeah I don't think I'm going to do anything more with it.

devilhorns accepted this revision.Jul 10 2018, 11:44 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 10 2018, 11:45 AM
Closed by commit rEFL9028fb5ac26e: tests/ecore: remove ecore-drm test (authored by zmike, committed by devilhorns). · Explain Why
This revision was automatically updated to reflect the committed changes.