Page MenuHomePhabricator
Differential D6597

tests: limit per-suite forks to cpu count
ClosedPublic
Actions

Authored by zmike on Jul 16 2018, 2:25 PM.

Details

Reviewers
bu5hm4n
stefan_schmidt
devilhorns
ManMower
Maniphest Tasks
T7151: 'make check' fails on the misc-disabled build on travis
Commits
rEFLbc7cbaffb5f6: tests: limit per-suite forks to cpu count
Summary

this is mostly fine to thrash the cpus on beefy desktop computers, but
it completely destroys travis's wimpy 2cpu/2gb ram configurations and causes
all the tests to fail

instead, restrict forking to the number of cpus detected and wait until a fork
exits before beginning a new one

ref T7151

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jul 16 2018, 2:25 PM
zmike requested review of this revision.Jul 16 2018, 2:25 PM
devilhorns accepted this revision.Jul 16 2018, 5:45 PM
devilhorns added a subscriber: devilhorns.

Looks good to me, but will wait for "release manager" ;) to sign-off

This revision is now accepted and ready to land.Jul 16 2018, 5:45 PM
ManMower added a subscriber: ManMower.Jul 16 2018, 6:07 PM
ManMower added inline comments.
src/tests/efl_check.h
287

ISTR WEXITSTATUS(foo) is only valid if WIFEXITED(foo) returns true?

Also, will all the child exit codes always be 1 or 0 or should be !! this?

333

This is pretty similar to the new code, and potentially shares the same issues, should this be made a function instead?

zmike added inline comments.Jul 17 2018, 7:38 AM
src/tests/efl_check.h
287

This is a good point, will add in followup patches.

333

Could be

zmike updated this revision to Diff 15707.Jul 17 2018, 7:53 AM
zmike added a reviewer: ManMower.

deduplicate code

ManMower accepted this revision.Jul 17 2018, 7:58 PM
Closed by commit rEFLbc7cbaffb5f6: tests: limit per-suite forks to cpu count (authored by zmike, committed by stefan_schmidt). · Explain WhyJul 25 2018, 1:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tests/efl_check.h (11 lines)

Diff 15857

View Options

src/tests/efl_check.h

Loading...