ci: use manual autoreconf && configure calls
ClosedPublic
Actions

As I mentioned in another review where you added the configure caches I think this was added when we had trouble with stale cache. I honestly do not remember details and as we are only using this on CI right now we should have enough control to use them. Just something to keep in mind when strange build problems happen.

.ci/ci-configure.sh
9	Is this removal on purpose or an accident? Seems unrelated to the rest of the patch.

The only issue we're likely to have is if we change any env vars during configure we'll have to manually delete the cache--configure will fail in this case anyway. The scripts handle a no-cache case, so it just requires deleting the cache in the travis ui or commenting out the line to move the cache files in the travis script.

.ci/ci-configure.sh
9	I think it just happened to be there and got stuck in this commit during one of the many rebases of this patchset.

stefan_schmidt accepted this revision.Jul 26 2018, 12:48 AM

This revision is now accepted and ready to land.Jul 26 2018, 12:48 AM

Closed by commit rEFLd568c6f12510: ci: use manual autoreconf && configure calls (authored by zmike, committed by stefan_schmidt). · Explain WhyJul 26 2018, 12:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			.ci/ci-configure.sh (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15725	51a12a3		Jul 17 2018, 1:49 PM	★	★
Diff 2	15796	b973642		Jul 23 2018, 4:44 AM	★	★
Diff 3	15875	9b2256e		Jul 25 2018, 8:51 AM	★	★
Diff 4	15924	6652373	rEFLd568c6f1251048e0e3378beccbf9d915ce12fa28	Jul 25 2018, 11:55 PM	★	★

Status	Author	Revision
Closed	zmike	D6789 ci: explicitly clone and build an external app during distcheck
Abandoned	zmike	D6735 ci: move distcheck build skipping to earliest possible place in build
Closed	zmike	D6788 ci: disable backtracing on log errors
Closed	zmike	D6734 ci: use manual script for distcheck build
Abandoned	zmike	D6733 ci: disable notifications for canceled builds
Closed	zmike	D6732 ci: automatically clear config.cache if it cannot be used
Closed	zmike	D6785 tests: add more info on failsafe timeout
Closed	zmike	D6697 tests: add failsafe timeout for tests running in fork mode
Closed	zmike	D6731 build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
Closed	zmike	D6666 ci: add build time to IRC notification
Closed	zmike	D6665 ci: remove --always-build-examples from misc build
Abandoned	zmike	D6664 ci: trigger distcheck only if build files changed or keyword present
Closed	zmike	D6663 ci: disable unnecessary build targets
Closed	zmike	D6662 build: remove infuriating VTIME build define
Abandoned	stefan_schmidt	D6661 ci: silence libtool
Closed	zmike	D6660 build: disable eolian implicit rules in subdir builds
Closed	zmike	D6659 build: use $(@D) for eolian directory name
Closed	zmike	D6658 ci: disable dependency tracking in ci builds
Closed	zmike	D6657 build: disable dependency tracking in distcheck builds
Closed	zmike	D6656 build: remove BUILT_SOURCES usage from cxx examples makefiles
Closed	zmike	D6655 ci: use gold linker for linux builds
Closed	zmike	D6654 ci: disable tests on macos
Closed	zmike	D6653 tests/ecore: remove tolerance threshold from ecore_timer_reset test case
Closed	zmike	D6652 ci: attempt to print the test logs if distcheck fails
Closed	zmike	D6651 ci: disable built-in make rules and variables
Closed	zmike	D6636 edje_cc: change .mo file write location to be relative to the .edj file
Closed	zmike	D6635 build: fix rpath for binaries which use ecore-x dependencies
Closed	zmike	D6634 build: use $() for automake variables, not ${}
Closed	zmike	D6633 build: move src/examples/ to a single makefile
Closed	zmike	D6623 tests/eio: increase monitoring test timeout to 1s
Abandoned	zmike	D6606 ci: add git install
Abandoned	zmike	D6622 ci: break out ccache stat printing into separate script
Abandoned	zmike	D6621 ci: zero ccache stats before build and add some comments for options used
Closed	zmike	D6620 ci: disable tests on misc builds
Closed	zmike	D6619 ci: make check -> make check-TESTS
Abandoned	zmike	D6618 ci: ignore time macros in ccache setup
Closed	zmike	D6617 ci: run make check in build
Closed	zmike	D6616 ci: add folding for travis logs
Closed	zmike	D6615 ci: use manual autoreconf && configure calls
Abandoned	zmike	D6614 ci: explicitly disable ccache for preprocessor usage
Abandoned	zmike	D6613 ci: split out ccache config setup into separate script
Closed	zmike	D6612 ci: make release-ready not allow failures
Closed	zmike	D6611 ci: disable make on release builds
Closed	zmike	D6584 ci: build tests on macos
Closed	zmike	D6610 ci: add osx homebrew packages to cache
Closed	zmike	D6609 ci: disable app build on osx
Closed	zmike	D6608 ci: add autoconf caching
Closed	zmike	D6607 ci: don't cd / when building example app
Closed	zmike	D6605 ci: add ccache support
Closed	zmike	D6604 ci: refactor all build steps into separate build scripts

Diff 15924

View Options

ci: use manual autoreconf && configure callsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 15924

.ci/ci-configure.sh

ci: use manual autoreconf && configure calls
ClosedPublic
Actions

Revision Contents
Changeset List