our autogen.sh stupidly destroys all the autotools cache files, so ensure that
we keep them around to speed up configure
Depends on D6612
our autogen.sh stupidly destroys all the autotools cache files, so ensure that
we keep them around to speed up configure
Depends on D6612
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
As I mentioned in another review where you added the configure caches I think this was added when we had trouble with stale cache. I honestly do not remember details and as we are only using this on CI right now we should have enough control to use them. Just something to keep in mind when strange build problems happen.
.ci/ci-configure.sh | ||
---|---|---|
9 | Is this removal on purpose or an accident? Seems unrelated to the rest of the patch. |
The only issue we're likely to have is if we change any env vars during configure we'll have to manually delete the cache--configure will fail in this case anyway. The scripts handle a no-cache case, so it just requires deleting the cache in the travis ui or commenting out the line to move the cache files in the travis script.
.ci/ci-configure.sh | ||
---|---|---|
9 | I think it just happened to be there and got stuck in this commit during one of the many rebases of this patchset. |