somehow ecore-x explicitly pulls in ${libdir}/libX11.so at link-time,
which causes libtool to add ${libdir} to the rpath executable wrappers
before the remainder of the in-tree efl paths. this causes binaries run
from these wrappers (e.g., tests, built-time tools such as codegens) to
use system libraries instead of in-tree libraries
@fix
Depends on D6634
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
@vtorri it would be great if you use your m4 wisdom here to help review if this patch is fine. I am always a bit scared when I see changes to our m4 macros. :-)
First of all, getting this long standing bug fixed would be great.
I understand the changes needed inside the m4 macro (minus my ignorance of the m4 syntax), but is the order change in the ecore makefile for LDADD needed as well? I would expect the change in the m4 macro would take care of it? Quite possible I am wrong here, but it looks strange to me.
The ecore-x libs have to be last-ish wherever they're listed, including in the makefiles.
As for the m4 changes, I don't think any particular expertise is needed to review this? It's just reordering existing code.
I had my troubles with re-ordered linker command lines before. :-) I am glad to have vtorri having a look first.