Details

Reviewers

bu5hm4n
stefan_schmidt
devilhorns

Summary

'cibuildme' , when placed in a commit log, will force
a distcheck build on CI if no build files have changed

also includes:

ci: move distcheck build skipping to earliest possible place in build

this breaks out the script to evaluate whether a distcheck should occur
into a separate file and runs it in the before_install hook, setting
a variable on skip

running configure or any commands at all is unnecessary if the distcheck
build will be skipped, so just update the last-distcheck file and abort
the build immediately to save time

ref D6735

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 7368

zmike created this revision.Jul 23 2018, 4:46 AM

Herald added a reviewer: devilhorns. · View Herald TranscriptJul 23 2018, 4:46 AM

Herald added subscribers: committers, cedric. · View Herald Transcript

zmike requested review of this revision.Jul 23 2018, 4:46 AM

zmike added a child revision: D6665: ci: remove --always-build-examples from misc build.

zmike planned changes to this revision.Jul 23 2018, 5:23 AM

zmike added inline comments.

.ci/ci-make-distcheck.sh
25	This has a bug: if the previous distcheck commit is no longer in history then the whole thing fails.

zmike mentioned this in T7159: review ci patchset.Jul 23 2018, 5:23 AM

check prev_distcheck commit hash to see if it's a valid commit in current

history

This + "only build examples in distcheck" results in the fact that examples are now only build if buildfiles are touched ? (Really not sure, thats why I ask)

This revision now requires changes to proceed.Aug 3 2018, 1:18 AM

That's correct. At present there is little work being done related to examples (other than my own changes to build system rules), so the examples themselves aren't changing, and any substantive changes to the tree which would break examples in the short term will require build file changes.

This change is also done under the assumption also that T7182 will be accomplished immediately after the release--which I am planning to tackle myself. Some tweaks can be made at a later point to fine tune this a bit.

zmike requested review of this revision.Aug 6 2018, 4:14 AM

A simple API change would break the examples and leave the buildfiles as they are. I am not a big fan of this, i remember @stefan_schmidt fixing examples a few times for releases, we could push that work to the committer with that, which is something that i would like to keep.

This revision now requires changes to proceed.Aug 6 2018, 4:21 AM

Again, at this point in the release there should not be changing of APIs in a way that affects the examples build. And post release it should no longer be relevant.

I can have it check for header files as well if transferring the examples out of repo takes longer than expected.

zmike requested review of this revision.Aug 6 2018, 11:58 AM

Sorry, but I do not want to have such a change before the release.

This can be part of the of the split out of the examples you plan to do.

Right now I am happy to have the CI spent more time on builds just to make sure the examples are fine.

We have enough situation where this can still break (c++ disabled or enabled will have different examples build, I just pushed two patches to examples themselves, there might still be API breaks detected that need fixing)

Cutting the build time by such assumptions is not the right time just before the release. Doing it afterwards is totally different. We can, and will, have to do more experimental changes to CI.

This revision now requires changes to proceed.Aug 16 2018, 2:35 AM

Herald added a subscriber: reviewers. · View Herald TranscriptAug 16 2018, 2:35 AM

stefan_schmidt mentioned this in D6734: ci: use manual script for distcheck build.Aug 16 2018, 3:15 AM

stefan_schmidt mentioned this in D6735: ci: move distcheck build skipping to earliest possible place in build.

reorder/squash some patches

Harbormaster completed remote builds in B7368: Diff 16355.Aug 16 2018, 6:26 AM

With the release done I am open for more experimental work like having heuristics when to build distcheck :-)

I commented on two more extensions we would need to check to make this heuristic a bit more safe.

What I can agree on is not running distcheck (especially the part where we create dist and check if all files are in CLEANFILES, etc) when build files are not touched.

The case I worry more about is the examples build. I don't think the heuristic on build files works to decide if they should build or not.

Maybe its time we move the examples build to a stage after the efl build and not inside the distcheck build?

This also depends on how the move of examples to a git submodule works out and in mid term also when we switch to meson. (the distcheck build equivalent would be very different and also faster)

There is also the option to have a Travis build triggered on a daily basis.

.ci/ci-make-distcheck.sh
22	This part came in as a separate patch by now. Needs updating.
.ci/distcheck-eval.sh
9	m4 and .in files might be also candidates for your grep here.
.travis.yml
80	why are do you using -z for the test here? Checking if the string length is zero does not make much sense. Why would you not check if the value is 1, as you set it above?

I am not sure this has much value anymore. With the full patch series, distcheck builds take around 20 minutes. I expect this to be reduced by 50-75% with a meson build. I will revisit it if this is no longer the case...

		Path
~		.ci/ci-make-distcheck.sh (20 lines)
A	M	.ci/distcheck-eval.sh (26 lines)
~		.travis.yml (34 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15819	ae55231		Jul 23 2018, 4:46 AM	★	★
Diff 2	15825	ae55231	check prev_distcheck commit hash to see if it's a valid commit in current	Jul 23 2018, 7:37 AM	★	★
Diff 3	15898	01f3774		Jul 25 2018, 8:53 AM	★	★
Diff 4	16067	1b22095		Aug 2 2018, 8:04 AM	★	★
Diff 5	16355	3f0618f	reorder/squash some patches	Aug 16 2018, 6:25 AM	★	★

Status	Author	Revision
Abandoned	zmike	D6606 ci: add git install
Abandoned	zmike	D6614 ci: explicitly disable ccache for preprocessor usage
Abandoned	zmike	D6613 ci: split out ccache config setup into separate script
Abandoned	zmike	D6618 ci: ignore time macros in ccache setup
Abandoned	zmike	D6622 ci: break out ccache stat printing into separate script
Abandoned	zmike	D6621 ci: zero ccache stats before build and add some comments for options used
Closed	zmike	D6789 ci: explicitly clone and build an external app during distcheck
Abandoned	zmike	D6735 ci: move distcheck build skipping to earliest possible place in build
Closed	zmike	D6788 ci: disable backtracing on log errors
Closed	zmike	D6734 ci: use manual script for distcheck build
Abandoned	zmike	D6733 ci: disable notifications for canceled builds
Closed	zmike	D6732 ci: automatically clear config.cache if it cannot be used
Closed	zmike	D6785 tests: add more info on failsafe timeout
Closed	zmike	D6697 tests: add failsafe timeout for tests running in fork mode
Closed	zmike	D6731 build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
Closed	zmike	D6666 ci: add build time to IRC notification
Closed	zmike	D6665 ci: remove --always-build-examples from misc build
Abandoned	zmike	D6664 ci: trigger distcheck only if build files changed or keyword present
Closed	zmike	D6663 ci: disable unnecessary build targets
Closed	zmike	D6662 build: remove infuriating VTIME build define
Abandoned	stefan_schmidt	D6661 ci: silence libtool
Closed	zmike	D6660 build: disable eolian implicit rules in subdir builds
Closed	zmike	D6659 build: use $(@D) for eolian directory name
Closed	zmike	D6658 ci: disable dependency tracking in ci builds
Closed	zmike	D6657 build: disable dependency tracking in distcheck builds
Closed	zmike	D6656 build: remove BUILT_SOURCES usage from cxx examples makefiles
Closed	zmike	D6655 ci: use gold linker for linux builds
Closed	zmike	D6654 ci: disable tests on macos
Closed	zmike	D6653 tests/ecore: remove tolerance threshold from ecore_timer_reset test case
Closed	zmike	D6652 ci: attempt to print the test logs if distcheck fails
Closed	zmike	D6651 ci: disable built-in make rules and variables
Closed	zmike	D6636 edje_cc: change .mo file write location to be relative to the .edj file
Closed	zmike	D6635 build: fix rpath for binaries which use ecore-x dependencies
Closed	zmike	D6634 build: use $() for automake variables, not ${}
Closed	zmike	D6633 build: move src/examples/ to a single makefile
Closed	zmike	D6623 tests/eio: increase monitoring test timeout to 1s
Closed	zmike	D6620 ci: disable tests on misc builds
Closed	zmike	D6619 ci: make check -> make check-TESTS
Closed	zmike	D6617 ci: run make check in build
Closed	zmike	D6616 ci: add folding for travis logs
Closed	zmike	D6615 ci: use manual autoreconf && configure calls
Closed	zmike	D6612 ci: make release-ready not allow failures
Closed	zmike	D6611 ci: disable make on release builds
Closed	zmike	D6584 ci: build tests on macos
Closed	zmike	D6610 ci: add osx homebrew packages to cache
Closed	zmike	D6609 ci: disable app build on osx
Closed	zmike	D6608 ci: add autoconf caching
Closed	zmike	D6607 ci: don't cd / when building example app
Closed	zmike	D6605 ci: add ccache support
Closed	zmike	D6604 ci: refactor all build steps into separate build scripts

ci: trigger distcheck only if build files changed or keyword present
AbandonedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 16355

.ci/ci-make-distcheck.sh

.ci/distcheck-eval.sh

.travis.yml

ci: trigger distcheck only if build files changed or keyword presentAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 16355

.ci/ci-make-distcheck.sh

.ci/distcheck-eval.sh

.travis.yml

ci: trigger distcheck only if build files changed or keyword present
AbandonedPublic
Actions

Revision Contents
Changeset List