Page MenuHomePhabricator

elm_test: fix arg parsing
ClosedPublic

Authored by zmike on Jul 23 2018, 10:24 AM.

Details

Summary

recent changes to ecore changed arg numbering again and no callers
outside of test suites were updated

ref 9c8749b99a03d3601321da6d16071dd7b631d1ae

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jul 23 2018, 10:24 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Jul 23 2018, 10:24 AM
zmike edited the summary of this revision. (Show Details)
devilhorns accepted this revision.Jul 23 2018, 10:32 AM
This revision is now accepted and ready to land.Jul 23 2018, 10:32 AM
This revision was automatically updated to reflect the committed changes.

Sorry to disturb but it seems that this patch has not verified "corner" cases such as launching only a test e.g:
elementary_test -to table

You are lucky, it fails with all the tests :-|

Please check

zmike added a comment.Jul 23 2018, 2:07 PM

Oops, I forgot how to count halfway through the patch. Will fix...

This is likely my fault...when I reviewed, I did not consider doing elm_test -t <some test> :(