Page MenuHomePhabricator

elementary: Check for valid cursor_rect when (un)setting focus
ClosedPublic

Authored by devilhorns on Jul 31 2018, 1:32 AM.

Details

Summary

As the cursor_rect for elm_code_widget is not created until the code
widget gets focus, we cannot just assume it is already there when
trying to emit a focus signal. The cursor_rect does not get created
until widget_cursor_update is called.

This fixes an issue where NULL is passed to efl_layout_signal_emit.

To test this, just launch elementary_test and click the Code Editor
test. As soon as you try to click into the Code Editor, this gets
triggered.

ref T7030

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
devilhorns created this revision.Jul 31 2018, 1:32 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

devilhorns updated this revision to Diff 15995.Jul 31 2018, 9:45 AM
This comment was removed by devilhorns.
netstar accepted this revision.Aug 14 2018, 7:44 AM
This revision is now accepted and ready to land.Aug 14 2018, 7:44 AM
This revision was automatically updated to reflect the committed changes.