Details
- Reviewers
Hermet - Maniphest Tasks
- T7030: efl internals pass null objects to functions which should not be passed null
Diff Detail
- Repository
- rEFL core/efl
- Branch
- devs/devilhorns/T7030
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 7120
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
I'm not seeing any errors related to this in the "Box Homogeneous" test. Is this the furthest up the stack that the issue can be resolved, or is it possible to block the sizing_eval altogether after invalidate?
Ugg, yea I can't reproduce this one now for some reason :( Should I just abandon this one then ?
If here efl_invalidation is neccesary, It' s really serious at efl. We can't add all this kind of stupid exceptional handling.
It's hard to expect when we need to check efl_invalidated_get() in function. Even right moment. Whatever this may fix some errors, we should not do this.
I disagree; I think it's important to avoid these calls where possible for both correctness and performance reasons.
With that said, a lot of these are like D6638 where there is a container widget manually triggering sizing_eval calls on subobject deletion. These containers should have the sizing_eval call blocked, which would avoid the need to add separate calls to every widget.