build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
ClosedPublic
Actions

Authored by zmike on Aug 2 2018, 8:02 AM.

Details

Reviewers

devilhorns
bu5hm4n

Commits

rEFLad81ef1364e4: build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites

Summary

this needs to be consistent so that it can be used reliably across suites

also these build flags really need to be consolidated into a single variable
that can be reused

Depends on D6666

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Aug 2 2018, 8:02 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike added a child revision: D6697: tests: add failsafe timeout for tests running in fork mode.Aug 2 2018, 8:04 AM

LGTM, i am wondering why this does not require any code changes ?

Setting the flag so its out of my queue.

This revision now requires changes to proceed.Aug 3 2018, 1:02 AM

This isn't used in many places.

Please do not reject a patch just to remove it from your view; that's now how review workflows work.

Well i was confused when i read the commit message with this content, and was afraid that the only reason for it to work could be that some #ifndef PACKAGE_BUILD_DIR #define PACKAGE_BUILD_DIR weirdness. Thus I requrested changes.

This revision is now accepted and ready to land.Aug 6 2018, 4:47 AM

Closed by commit rEFLad81ef1364e4: build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites (authored by zmike). · Explain WhyAug 8 2018, 6:45 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: reviewers. · View Herald TranscriptAug 8 2018, 6:45 AM

Revision Contents
Changeset List

			Path	Packages
M			src/Makefile_Cxx.am (8 lines)
M			src/Makefile_Ecore.am (2 lines)
M			src/Makefile_Ecore_Con.am (1 line)
M			src/Makefile_Eet.am (1 line)
M			src/Makefile_Eeze.am (1 line)
M			src/Makefile_Efl.am (1 line)
M			src/Makefile_Efl_Js.am (2 lines)
M			src/Makefile_Efreet.am (1 line)
M			src/Makefile_Eio.am (1 line)
M			src/Makefile_Eldbus.am (1 line)
M			src/Makefile_Elementary.am (2 lines)
M			src/Makefile_Elocation.am (1 line)
M			src/Makefile_Elput.am (1 line)
M			src/Makefile_Emile.am (1 line)
M			src/Makefile_Eo.am (1 line)
M			src/Makefile_Eolian.am (1 line)
M			src/Makefile_Eolian_Cxx.am (2 lines)
M			src/Makefile_Eolian_Js.am (2 lines)
M			src/Makefile_Evas.am (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16060	2a23cd6		Aug 2 2018, 8:02 AM	★	★
Diff 2	16070	0120477		Aug 2 2018, 8:04 AM	★	★
Diff 3	16196	d3f8ca2	rEFLad81ef1364e4035bda527c61c47c2cad193b8e78	Aug 8 2018, 6:45 AM	★	★

Status	Author	Revision
Abandoned	zmike	D6606 ci: add git install
Abandoned	zmike	D6614 ci: explicitly disable ccache for preprocessor usage
Abandoned	zmike	D6613 ci: split out ccache config setup into separate script
Abandoned	zmike	D6618 ci: ignore time macros in ccache setup
Abandoned	zmike	D6622 ci: break out ccache stat printing into separate script
Abandoned	zmike	D6621 ci: zero ccache stats before build and add some comments for options used
Closed	zmike	D6789 ci: explicitly clone and build an external app during distcheck
Abandoned	zmike	D6735 ci: move distcheck build skipping to earliest possible place in build
Closed	zmike	D6788 ci: disable backtracing on log errors
Closed	zmike	D6734 ci: use manual script for distcheck build
Abandoned	zmike	D6733 ci: disable notifications for canceled builds
Closed	zmike	D6732 ci: automatically clear config.cache if it cannot be used
Closed	zmike	D6785 tests: add more info on failsafe timeout
Closed	zmike	D6697 tests: add failsafe timeout for tests running in fork mode
Closed	zmike	D6731 build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
Closed	zmike	D6666 ci: add build time to IRC notification
Closed	zmike	D6665 ci: remove --always-build-examples from misc build
Abandoned	zmike	D6664 ci: trigger distcheck only if build files changed or keyword present
Closed	zmike	D6663 ci: disable unnecessary build targets
Closed	zmike	D6662 build: remove infuriating VTIME build define
Abandoned	stefan_schmidt	D6661 ci: silence libtool
Closed	zmike	D6660 build: disable eolian implicit rules in subdir builds
Closed	zmike	D6659 build: use $(@D) for eolian directory name
Closed	zmike	D6658 ci: disable dependency tracking in ci builds
Closed	zmike	D6657 build: disable dependency tracking in distcheck builds
Closed	zmike	D6656 build: remove BUILT_SOURCES usage from cxx examples makefiles
Closed	zmike	D6655 ci: use gold linker for linux builds
Closed	zmike	D6654 ci: disable tests on macos
Closed	zmike	D6653 tests/ecore: remove tolerance threshold from ecore_timer_reset test case
Closed	zmike	D6652 ci: attempt to print the test logs if distcheck fails
Closed	zmike	D6651 ci: disable built-in make rules and variables
Closed	zmike	D6636 edje_cc: change .mo file write location to be relative to the .edj file
Closed	zmike	D6635 build: fix rpath for binaries which use ecore-x dependencies
Closed	zmike	D6634 build: use $() for automake variables, not ${}
Closed	zmike	D6633 build: move src/examples/ to a single makefile
Closed	zmike	D6623 tests/eio: increase monitoring test timeout to 1s
Closed	zmike	D6620 ci: disable tests on misc builds
Closed	zmike	D6619 ci: make check -> make check-TESTS
Closed	zmike	D6617 ci: run make check in build
Closed	zmike	D6616 ci: add folding for travis logs
Closed	zmike	D6615 ci: use manual autoreconf && configure calls
Closed	zmike	D6612 ci: make release-ready not allow failures
Closed	zmike	D6611 ci: disable make on release builds
Closed	zmike	D6584 ci: build tests on macos
Closed	zmike	D6610 ci: add osx homebrew packages to cache
Closed	zmike	D6609 ci: disable app build on osx
Closed	zmike	D6608 ci: add autoconf caching
Closed	zmike	D6607 ci: don't cd / when building example app
Closed	zmike	D6605 ci: add ccache support
Closed	zmike	D6604 ci: refactor all build steps into separate build scripts

build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suitesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 16196

src/Makefile_Cxx.am

src/Makefile_Ecore.am

src/Makefile_Ecore_Con.am

src/Makefile_Eet.am

src/Makefile_Eeze.am

src/Makefile_Efl.am

src/Makefile_Efl_Js.am

src/Makefile_Efreet.am

src/Makefile_Eio.am

src/Makefile_Eldbus.am

src/Makefile_Elementary.am

src/Makefile_Elocation.am

src/Makefile_Elput.am

src/Makefile_Emile.am

src/Makefile_Eo.am

src/Makefile_Eolian.am

src/Makefile_Eolian_Cxx.am

src/Makefile_Eolian_Js.am

src/Makefile_Evas.am

build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
ClosedPublic
Actions

Revision Contents
Changeset List