ci: move distcheck build skipping to earliest possible place in build
AbandonedPublic
Actions

Authored by zmike on Aug 2 2018, 12:27 PM.

Details

Reviewers

Summary

this breaks out the script to evaluate whether a distcheck should occur
into a separate file and runs it in the before_install hook, setting
a variable on skip

running configure or any commands at all is unnecessary if the distcheck
build will be skipped, so just update the last-distcheck file and abort
the build immediately to save time
Depends on D6734

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 7177

zmike created this revision.Aug 2 2018, 12:27 PM

Herald added subscribers: committers, cedric. · View Herald TranscriptAug 2 2018, 12:27 PM

zmike requested review of this revision.Aug 2 2018, 12:27 PM

in action: https://travis-ci.org/Enlightenment/efl/jobs/411403519

zmike mentioned this in T7159: review ci patchset.Aug 2 2018, 1:25 PM

zmike added a child revision: D6789: ci: explicitly clone and build an external app during distcheck.Aug 8 2018, 12:03 PM

Herald added a subscriber: reviewers. · View Herald TranscriptAug 8 2018, 12:03 PM

As I commented in D6664 I think we should not do this kind of heuristics when to run distcheck just before a release. Giving up some build time on CI until the release is out is fine. We can re-visited once that is done.

This revision now requires changes to proceed.Aug 16 2018, 3:17 AM

zmike mentioned this in D6664: ci: trigger distcheck only if build files changed or keyword present.Aug 16 2018, 6:26 AM

zmike removed a parent revision: D6734: ci: use manual script for distcheck build.Aug 16 2018, 6:29 AM

zmike added a parent revision: D6734: ci: use manual script for distcheck build.

This seems to be now part of D6664. In that case we should abandon this one.

zmike abandoned this revision.Aug 21 2018, 7:34 AM

Revision Contents
Changeset List

		Path
~		.ci/ci-make-distcheck.sh (42 lines)
A	M	.ci/distcheck-eval.sh (26 lines)
~		.travis.yml (34 lines)

Commit	Tree	Parents	Author	Summary	Date
fd6b2e3d9023	bc94f697a7b9	3fd4e57c09ed	Mike Blumenkrantz	(Show More…)	Aug 2 2018, 10:29 AM

Status	Author	Revision
Abandoned	zmike	D6606 ci: add git install
Abandoned	zmike	D6614 ci: explicitly disable ccache for preprocessor usage
Abandoned	zmike	D6613 ci: split out ccache config setup into separate script
Abandoned	zmike	D6618 ci: ignore time macros in ccache setup
Abandoned	zmike	D6622 ci: break out ccache stat printing into separate script
Abandoned	zmike	D6621 ci: zero ccache stats before build and add some comments for options used
Closed	zmike	D6785 tests: add more info on failsafe timeout
Closed	zmike	D6788 ci: disable backtracing on log errors
Closed	zmike	D6789 ci: explicitly clone and build an external app during distcheck
Abandoned	zmike	D6735 ci: move distcheck build skipping to earliest possible place in build
Closed	zmike	D6734 ci: use manual script for distcheck build
Abandoned	zmike	D6733 ci: disable notifications for canceled builds
Closed	zmike	D6732 ci: automatically clear config.cache if it cannot be used
Closed	zmike	D6697 tests: add failsafe timeout for tests running in fork mode
Closed	zmike	D6731 build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
Closed	zmike	D6666 ci: add build time to IRC notification
Closed	zmike	D6665 ci: remove --always-build-examples from misc build
Abandoned	zmike	D6664 ci: trigger distcheck only if build files changed or keyword present
Closed	zmike	D6663 ci: disable unnecessary build targets
Closed	zmike	D6662 build: remove infuriating VTIME build define
Abandoned	stefan_schmidt	D6661 ci: silence libtool
Closed	zmike	D6660 build: disable eolian implicit rules in subdir builds
Closed	zmike	D6659 build: use $(@D) for eolian directory name
Closed	zmike	D6658 ci: disable dependency tracking in ci builds
Closed	zmike	D6657 build: disable dependency tracking in distcheck builds
Closed	zmike	D6656 build: remove BUILT_SOURCES usage from cxx examples makefiles
Closed	zmike	D6655 ci: use gold linker for linux builds
Closed	zmike	D6654 ci: disable tests on macos
Closed	zmike	D6653 tests/ecore: remove tolerance threshold from ecore_timer_reset test case
Closed	zmike	D6652 ci: attempt to print the test logs if distcheck fails
Closed	zmike	D6651 ci: disable built-in make rules and variables
Closed	zmike	D6636 edje_cc: change .mo file write location to be relative to the .edj file
Closed	zmike	D6635 build: fix rpath for binaries which use ecore-x dependencies
Closed	zmike	D6634 build: use $() for automake variables, not ${}
Closed	zmike	D6633 build: move src/examples/ to a single makefile
Closed	zmike	D6623 tests/eio: increase monitoring test timeout to 1s
Closed	zmike	D6620 ci: disable tests on misc builds
Closed	zmike	D6619 ci: make check -> make check-TESTS
Closed	zmike	D6617 ci: run make check in build
Closed	zmike	D6616 ci: add folding for travis logs
Closed	zmike	D6615 ci: use manual autoreconf && configure calls
Closed	zmike	D6612 ci: make release-ready not allow failures
Closed	zmike	D6611 ci: disable make on release builds
Closed	zmike	D6584 ci: build tests on macos
Closed	zmike	D6610 ci: add osx homebrew packages to cache
Closed	zmike	D6609 ci: disable app build on osx
Closed	zmike	D6608 ci: add autoconf caching
Closed	zmike	D6607 ci: don't cd / when building example app
Closed	zmike	D6605 ci: add ccache support
Closed	zmike	D6604 ci: refactor all build steps into separate build scripts

Diff 16075

View Options

.ci/ci-make-distcheck.sh

View Options

.ci/distcheck-eval.sh

View Options

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16075	3fd4e57		Aug 2 2018, 12:27 PM	★	★

ci: move distcheck build skipping to earliest possible place in buildAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 16075

.ci/ci-make-distcheck.sh

.ci/distcheck-eval.sh

.travis.yml

ci: move distcheck build skipping to earliest possible place in build
AbandonedPublic
Actions

Revision Contents
Changeset List