Page MenuHomePhabricator

ci: move distcheck build skipping to earliest possible place in build
AbandonedPublic

Authored by zmike on Aug 2 2018, 12:27 PM.

Details

Reviewers
stefan_schmidt
Summary

this breaks out the script to evaluate whether a distcheck should occur
into a separate file and runs it in the before_install hook, setting
a variable on skip

running configure or any commands at all is unnecessary if the distcheck
build will be skipped, so just update the last-distcheck file and abort
the build immediately to save time
Depends on D6734

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7177
zmike created this revision.Aug 2 2018, 12:27 PM
zmike requested review of this revision.Aug 2 2018, 12:27 PM
stefan_schmidt requested changes to this revision.Aug 16 2018, 3:17 AM

As I commented in D6664 I think we should not do this kind of heuristics when to run distcheck just before a release. Giving up some build time on CI until the release is out is fine. We can re-visited once that is done.

This revision now requires changes to proceed.Aug 16 2018, 3:17 AM

This seems to be now part of D6664. In that case we should abandon this one.

zmike abandoned this revision.Aug 21 2018, 7:34 AM