Page MenuHomePhabricator

elm/naviframe: implement invalidate method for naviframe items
ClosedPublic

Authored by zmike on Aug 6 2018, 11:44 AM.

Details

Summary

move most of the _item_free() calls to the invalidate method and unset some
delete callbacks on content items to avoid invalid calls during deletion

calling any of this during the object destructor is invalid because the parent
object can no longer be accessed at this time

fix T7236

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Aug 6 2018, 11:44 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Aug 6 2018, 11:44 AM

@Jaehyun_Cho it would be good if you could give this patch a review soon. It is supposed to fix one of the showstopper issues we have for the efl 1.20 release

We have the confirmation now form the bug reporter in T7236 that this patch fixes the problem for him.

@Jaehyun_Cho if you want to review this patch do it soon as I will go ahead and pull this patch in tomorrow. It fixes a known regression and was confirmed so I would like to have this in rather sooner than later.

Jaehyun_Cho accepted this revision.Aug 12 2018, 11:07 PM
This revision is now accepted and ready to land.Aug 12 2018, 11:07 PM
This revision was automatically updated to reflect the committed changes.