Differential D6779

efl_ui_tab_bar: implement select key bindings.
ClosedPublic
Actions

Authored by bowonryu on Aug 8 2018, 5:16 AM.

Tags

Subscribers

YOhoho, cedric, reviewers and 2 others

Details

Reviewers

Jaehyun_Cho
Hermet

Commits

rEFL522c5250abd5: efl_ui_tab_bar: implement select key bindings.

Summary

by key bindings..
now we can select TAB with the Return/Space key.

Test Plan

elementary_test -to efl.ui.tab_pager

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7261
Build 6961: arc lint + arc unit

bowonryu created this revision.Aug 8 2018, 5:16 AM

Herald added a project: efl. · View Herald TranscriptAug 8 2018, 5:16 AM

Herald added subscribers: zmike, committers, reviewers, cedric. · View Herald Transcript

bowonryu requested review of this revision.Aug 8 2018, 5:16 AM

Harbormaster completed remote builds in B7261: Diff 16186.Aug 8 2018, 5:16 AM

@Hermet
is it unnecessary to increase config_version?

modify select logic.

Harbormaster completed remote builds in B7287: Diff 16228.Aug 8 2018, 7:56 PM

Please update config_version as @YOhoho asked.

You need to change ELM_CONFIG_FILE_GENERATION to 0x0012 and and config_version to 13190. (Please calculate the config_version.)

Jaehyun_Cho requested changes to this revision.Aug 13 2018, 9:35 PM

This revision now requires changes to proceed.Aug 13 2018, 9:35 PM

update config_version

Harbormaster completed remote builds in B7401: Diff 16420.Aug 20 2018, 4:12 AM

update for mobile profile.

Harbormaster completed remote builds in B7413: Diff 16448.Aug 20 2018, 11:29 PM

Jaehyun_Cho accepted this revision.Aug 20 2018, 11:31 PM

This revision is now accepted and ready to land.Aug 20 2018, 11:31 PM

Closed by commit rEFL522c5250abd5: efl_ui_tab_bar: implement select key bindings. (authored by bowonryu, committed by Jaehyun_Cho). · Explain WhyAug 20 2018, 11:52 PM

This revision was automatically updated to reflect the committed changes.

bu5hm4n mentioned this in D7776: efl_ui_scroller: apply handling focus..Feb 13 2019, 3:23 AM

Revision Contents
Changeset List

			Path	Packages
M			data/elementary/config/default/base.src.in (23 lines)
M			data/elementary/config/standard/base.src.in (23 lines)
M			src/lib/elementary/efl_ui_tab_bar.c (31 lines)
M			src/lib/elementary/efl_ui_tab_bar.eo (1 line)

Diff 16186

data/elementary/config/default/base.src.in

Loading...

data/elementary/config/standard/base.src.in

Loading...

src/lib/elementary/efl_ui_tab_bar.c

Loading...

src/lib/elementary/efl_ui_tab_bar.eo

Loading...