the elementary MARKUP stuff requires ecore_cocoa to be linked to evas to
find the function. However, ecore_XXXXX things should stay unrelated to
evas in most cases. Thus this was not a good idea and created a circular
dependency, this is fixed now.
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
Comment Actions
Have the MARKUP enum value do nothing when passed and this seems like a reasonable solution.
| src/lib/ecore_cocoa/Ecore_Cocoa.h | ||
|---|---|---|
| 209 ↗ | (On Diff #16408) | This enum is not beta and must not be changed. |
Comment Actions
Also should remove the evas (and possibly emile?) dependencies from configure.ac around L3600.
| src/lib/elementary/efl_selection_manager.c | ||
|---|---|---|
| 4014 | We have previously assigned sel->data (by duplicating memory: sel->data = eina_slice_dup(data);). This could maybe be avoided. Also, I don't understand why to do not directly assign sel->data to result. If I understand correctly:
So I believe we should just assign result to sel->data, and therefore avoid a memory allocation, and associated memory leak. | |
This comment was removed by bu5hm4n.