Page MenuHomePhabricator

build: remove src/benchmarks from tree
AbandonedPublic

Authored by bu5hm4n on Aug 20 2018, 2:37 PM.

Details

Summary

these are no longer used for anything

fix T7183

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7410
zmike created this revision.Aug 20 2018, 2:37 PM
zmike requested review of this revision.Aug 20 2018, 2:37 PM
stefan_schmidt added subscribers: bu5hm4n, raster.

Its been a while since you submitted this. Since the I can see 8 commits in src/benchmarks and a complete new benchmark for focus widget tree being added. I would not call it unused.
It also works fine with ninja benchmark for me.

In my opinion benchmarks could stay without much of an overhead for us. I am giving you though that I am not actively using them. Wondering if @cedric, @bu5hm4n or @raster doing so.

zmike added a comment.Jan 28 2019, 9:34 AM

Its been a while since you submitted this. Since the I can see 8 commits in src/benchmarks and a complete new benchmark for focus widget tree being added. I would not call it unused.
It also works fine with ninja benchmark for me.

In my opinion benchmarks could stay without much of an overhead for us. I am giving you though that I am not actively using them. Wondering if @cedric, @bu5hm4n or @raster doing so.

There has been exactly 1 functional change to this directory since 2016 (I stopped looking through history at this point). It's worth keeping the focus benchmark which was just added, but nothing else seems useful/used in any way.

This is realistically never landing, (there was a thread regarding this on the ML) Only the two of us love that, the rest hates it. So we just abonde this ?

bu5hm4n commandeered this revision.Jul 9 2019, 2:01 AM
bu5hm4n abandoned this revision.
bu5hm4n edited reviewers, added: zmike; removed: bu5hm4n.