Page MenuHomePhabricator

build: move examples to submodule
Needs ReviewPublic

Authored by zmike on Aug 20 2018, 2:48 PM.

Details

Summary

this speeds up both the normal tree build and the examples builds as
well as moving all examples into the same repo

fix T7182

Diff Detail

Repository
rEFL core/efl
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 7411
zmike created this revision.Aug 20 2018, 2:48 PM
zmike requested review of this revision.Aug 20 2018, 2:48 PM
zmike added a comment.Aug 20 2018, 2:52 PM

I had to manually upload this diff from a file because git-phab exploded when I tried to run it normally.

Completed CI build of recent patches (with random distcheck fail due to missing D6877):

https://travis-ci.org/Enlightenment/efl/builds/418418243
https://travis-ci.org/Enlightenment/efl/builds/418394830

bu5hm4n added a subscriber: bu5hm4n.Nov 2 2018, 7:33 AM

@zmike ... this does not compile for me

ecore_animator_example.c:4:10: fatal error: Ecore.h: No such file or directory
 #include <Ecore.h>
          ^~~~~~~~~
compilation terminated.
make[1]: *** [Makefile.examples:76: ecore_animator_example] Error 1
make[1]: Leaving directory '/home/marcel/git/examples/unsorted/ecore'
make: *** [Makefile:23: all] Error 1

More over is it possible to have the integration patch use meson to build the legacy-examples ? (I have sorted the unsorted folder in a branch in the examples repository)

zmike added a comment.Nov 2 2018, 7:55 AM

@zmike ... this does not compile for me

ecore_animator_example.c:4:10: fatal error: Ecore.h: No such file or directory
 #include <Ecore.h>
          ^~~~~~~~~
compilation terminated.
make[1]: *** [Makefile.examples:76: ecore_animator_example] Error 1
make[1]: Leaving directory '/home/marcel/git/examples/unsorted/ecore'
make: *** [Makefile:23: all] Error 1

This is a user error and not something I can control. As seen above, CI builds succeed with proper configuration. If you are attempting a fully in-tree build then you will need to set environment variables appropriately as in distcheck.sh.

More over is it possible to have the integration patch use meson to build the legacy-examples ? (I have sorted the unsorted folder in a branch in the examples repository)

You're free to do whatever you like; this patch was written and tested months ago based on the current status of things at that time.

It's unlikely that I will have time to do any changes related to this until next year at the earliest, so you are welcome to either land this as-is or use it as a reference for submodule integration.