Page MenuHomePhabricator

eolian-cxx: Add dummy -S parameter to be compatible with eolian variable in pkgconfig
Needs ReviewPublic

Authored by felipealmeida on Aug 22 2018, 7:39 PM.

Details

Reviewers
stefan_schmidt

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D6895
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8785
Build 7732: arc lint + arc unit
felipealmeida created this revision.Aug 22 2018, 7:39 PM
felipealmeida requested review of this revision.Aug 22 2018, 7:39 PM

What's the goal of this? The commit message does not explain it.
The command description "Ignore" seems a bit confusing too.

pkgconfig sets parameters for eolian_gen which include -S parameters. But if the same variable is passed as parameters to eolian_cxx they fail because eolian_cxx doesn't understand -S parameter. Which it doesn't need to understand, but it shouldn't fail.

stefan_schmidt requested changes to this revision.Aug 24 2018, 2:53 AM
stefan_schmidt added a subscriber: Unknown Object (User).

I think @xavi would have liked your explanatio in the commit message (as an updated patch) itself and not only here in the review system.

With these two changes I would be ok with the patch.

src/bin/eolian_cxx/eolian_cxx.cc
433

How about. "Will be ignored, only for eolian_gen compatibility"?

This revision now requires changes to proceed.Aug 24 2018, 2:53 AM

Added description in commit

I cannot find -S in a .pc file ...