Page MenuHomePhabricator

efl-csharp: Make sure efl_finalize overrides are callable
ClosedPublic

Authored by lauromoura on Aug 30 2018, 9:09 PM.

Details

Summary

efl_finalize override is called inside efl_add_end. Previously by this
time the constructor still hadn't saved the C# wrapper handle into the
Eo instance private data, to be recovered in the static delegates that
call the C# overrides.

This commit just changes the order to save the C# handle *before*
calling efl_add_end.

Test Plan

added unit test to be run with make check

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Aug 30 2018, 9:09 PM
lauromoura requested review of this revision.Aug 30 2018, 9:09 PM
vitor.sousa accepted this revision.Sep 3 2018, 12:45 PM
This revision is now accepted and ready to land.Sep 3 2018, 12:45 PM

@vitor.sousa

Hello~
is there any reason why you do not submit this patch to master branch?

Hello @Jaehyun_Cho.
It's, working for me. But I heard that it was not working on dotnet for you, so I was waiting another review on it.
But since it seems to be fine and that the dotnet problem needs further and separated investigation, I am going to submit it right away.

This revision was automatically updated to reflect the committed changes.