Page MenuHomePhabricator

elm_gengrid: fix item_show / bring_in deferred call.
ClosedPublic

Authored by SanghyeonLee on Sep 9 2018, 11:09 PM.

Details

Summary

item_show / bring_in will be deferred, if object is not resized properly.
the deferred call of item_show_region() is on the calc_job(),
after calculating proper object, pan size, but still item is not placed,
so target scrolling position is wrong while item_show_region().

move deferred call to group_calculate() to get correct item position,
after item_place() and group_item_place() were processed.

This patch is reported on T7367.

Test Plan

{F3302967}please check attached gengrid_example_01.c

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7604
Build 7169: arc lint + arc unit
SanghyeonLee created this revision.Sep 9 2018, 11:09 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

SanghyeonLee requested review of this revision.Sep 9 2018, 11:09 PM
SanghyeonLee edited the summary of this revision. (Show Details)Sep 9 2018, 11:11 PM
SanghyeonLee edited the test plan for this revision. (Show Details)
SanghyeonLee added subscribers: Hermet, eagleeye.

rebasing patch

Hermet accepted this revision.Sep 18 2018, 5:16 PM
This revision is now accepted and ready to land.Sep 18 2018, 5:16 PM
This revision was automatically updated to reflect the committed changes.