Page MenuHomePhabricator

ecore_wl2: Move surface module file to modules directory
ClosedPublic

Authored by ManMower on Sep 10 2018, 12:39 PM.

Details

Summary

It is now similar to how other modules are handled.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ManMower created this revision.Sep 10 2018, 12:39 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ManMower requested review of this revision.Sep 10 2018, 12:39 PM
bu5hm4n accepted this revision.Sep 10 2018, 1:00 PM
bu5hm4n awarded a token.
This revision is now accepted and ready to land.Sep 10 2018, 1:00 PM
devilhorns requested changes to this revision.Sep 10 2018, 1:12 PM
devilhorns added a subscriber: devilhorns.

Are we planning on having more than one module for ecore_wl2 ?? If not, then I don't see the point of this ... If we Are planning on more than one module, then ok

This revision now requires changes to proceed.Sep 10 2018, 1:12 PM

@devilhorns everything that is build into a module is located in src/modules so should this be located there, this just restores consistency accross the tree :)

devilhorns accepted this revision.Sep 10 2018, 5:48 PM

Ah ok, well that makes some sense then

This revision is now accepted and ready to land.Sep 10 2018, 5:48 PM
Closed by commit rEFLb43033e39397: ecore_wl2: Move surface module file to modules directory (authored by ManMower, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhySep 11 2018, 1:01 AM
This revision was automatically updated to reflect the committed changes.