Page MenuHomePhabricator

evas_events: NULL check before evas_event_freezes_through.
AbandonedPublic

Authored by netstar on Sep 12 2018, 3:01 AM.

Details

Summary

In some cases focused_obj can be NULL. Add a check before
calling evas_event_freezes_through. Was causing a SEGV
in some situations.

Test Plan
  • elementary_test -> popup
  • open "popup-center-text" + 3 button (check, add, remove buttons).
  • close popup with button. Press a key afterwards. (repeat).
  • The test should no longer crash.

Diff Detail

Repository
rEFL core/efl
Branch
workz
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7619
Build 7180: arc lint + arc unit
netstar created this revision.Sep 12 2018, 3:01 AM
netstar requested review of this revision.Sep 12 2018, 3:01 AM

This isn't a fix really. All it does is prevents a crash when the focus tree breaks...Basically rather than crash the application just loses all input from keyboard.....

netstar abandoned this revision.Sep 12 2018, 11:03 AM

Closing this.

I would like to merge this anyways ... i mean, it prevents illegal memory access, but maybe it should be a WARN, so its not a gebugging nightmare.