Page MenuHomePhabricator

efl_ui_focus_manager_calc: invalidate obj on delete.
ClosedPublic

Authored by netstar on Sep 12 2018, 10:58 AM.

Details

Summary

In some situations focus is being set to a deleted object.
Use EFL_EVENT_INVALIDATE on object deletion not
EFL_EVENT_DEL. This prevents the object to be again selected for restoring focus when a redirect is deleted.

This fixes SEGV with some widgets including popup tests.

Test Plan
  • elementary_test -to popup
  • popup-center-text + 3 button (check add, remove buttons).
  • Close popup, enter text (reopen popup and repeat).
  • Crash should be avoided.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
netstar created this revision.Sep 12 2018, 10:58 AM
netstar requested review of this revision.Sep 12 2018, 10:58 AM
bu5hm4n accepted this revision.Sep 12 2018, 11:53 AM
bu5hm4n edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 12 2018, 11:53 AM
This revision was automatically updated to reflect the committed changes.