Page MenuHomePhabricator

GUI: Code clean up and bug fix for tab.
ClosedPublic

Authored by bowonryu on Sep 14 2018, 1:19 AM.

Details

Reviewers
JackDanielZ
Summary

When the file already opened on tab,
fixed a bug that expanded tabs in explorer would not display properly on tabs when collapsed.

and I modified the code structure to suit this.

Test Plan
  1. add some tabs.
  2. collapse the directory in the file explorer. (parent directory of opend tab)
  3. select tab.
  4. directory tree is expanded and file is selected.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7634
Build 7192: arc lint + arc unit
bowonryu requested review of this revision.Sep 14 2018, 1:19 AM
bowonryu created this revision.
JackDanielZ accepted this revision.Sep 15 2018, 10:14 AM
This revision is now accepted and ready to land.Sep 15 2018, 10:14 AM
JackDanielZ closed this revision.Sep 15 2018, 10:14 AM