Page MenuHomePhabricator

efl_ui_tab_pager : Fix type mismatch for calloc
ClosedPublic

Authored by jsuya on Sep 19 2018, 12:01 AM.

Details

Summary

Fix type mismatch.
The return value of function 'calloc' is cast to type 'App_Data *',
which doesn't match the sizeof expression 'sizeof (ad)' passed as its 2nd argument 'sizeof (ad)'.
The size of the result is 8 bytes, value of the sizeof expression is 4.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7686
Build 7226: arc lint + arc unit
jsuya created this revision.Sep 19 2018, 12:01 AM
jsuya requested review of this revision.Sep 19 2018, 12:01 AM
jsuya updated this revision to Diff 16862.Sep 19 2018, 12:10 AM

Add sizeof mismatch fix

jsuya updated this revision to Diff 16863.Sep 19 2018, 12:12 AM

update code

bowonryu accepted this revision.Sep 19 2018, 12:14 AM

This seems necessary.

This revision is now accepted and ready to land.Sep 19 2018, 12:14 AM
jsuya updated this revision to Diff 16864.Sep 19 2018, 12:37 AM

update code

jsuya retitled this revision from efl_ui_tab_pager : Add null check to efl_ui_tab_pager : Fix type mismatch for calloc.Sep 19 2018, 12:38 AM
jsuya edited the summary of this revision. (Show Details)
SanghyeonLee accepted this revision.Sep 19 2018, 12:39 AM
SanghyeonLee closed this revision.Sep 19 2018, 12:45 AM