Page MenuHomePhabricator

efl-csharp: Fixing C# examples
ClosedPublic

Authored by lauromoura on Oct 3 2018, 12:23 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Oct 3 2018, 12:23 PM
lauromoura requested review of this revision.Oct 3 2018, 12:23 PM
lauromoura updated this revision to Diff 17012.Oct 3 2018, 12:32 PM

Update with SetIcon change from D7133

segfaultxavi added inline comments.
src/examples/elementary/efl_ui_unit_converter.cs
24

No need for this comment. History should be recorded in the git log, not the code.

I confirm this fixes the examples for me. Just remove that comment.

lauromoura updated this revision to Diff 17030.Oct 4 2018, 10:12 AM

Update removing the comment. Somehow I forgot it when splitting the patches.

lauromoura marked an inline comment as done.Oct 4 2018, 10:12 AM
segfaultxavi accepted this revision.Oct 4 2018, 10:14 AM
This revision is now accepted and ready to land.Oct 4 2018, 10:14 AM
This revision was automatically updated to reflect the committed changes.