Page MenuHomePhabricator

evas_render: fix objects change occured withoout real rendering.
ClosedPublic

Authored by jypark on Oct 28 2018, 5:09 PM.

Details

Summary

: condition of problem

  • rectangle object of RECT part(BASE part of below edje)
  • mapped
  • has clipper and clipper is ed's base clipper.
  1. _evas_render_phase1_object_process is called of rect object

if rect is mapped, not changed, it call _evas_render_phase1_object_mapped.

  1. _evas_render_phase1_object_mapped

when _evas_render_phase1_object_mapped is called,
condition is
src_changed=0 , is_active=0 , obj_changed=0
hmap=0 => because map of this object is only enabled once and not changed.

in this case, rect object's clipper always changed and it cause useless randering

so only call _evas_render_phase1_object_map_clipper_fix when obj is changed.
first time of map set, evas object always be changed, so it maybe ok we call clipper_fix only obj is chaned.

below is sample of edj.

group { name: "elm/notify/center/default";

parts {
   part { name: "anim_start";
          scale: 1;
          type: SPACER;
          description {

..

      perspective {
                     zplane: -100;
                     focal: 1000;
                  }
           }
}
  part { name: "anim_stop";
     scale: 1;
     type: SPACER;
     description {

..

       perspective {
                       zplane: 0;
                       focal: 1000;
                    }
             }
  }
part { name: "base";
       scale: 1;
   type: RECT;
   description { state: "default" 0.0;

..

      map {
          on: 1;
          perspective_on: 1;
          perspective: "anim_stop";
     }
   }
}

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jypark created this revision.Oct 28 2018, 5:09 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

jypark requested review of this revision.Oct 28 2018, 5:09 PM
Hermet accepted this revision.Nov 4 2018, 9:20 PM
This revision is now accepted and ready to land.Nov 4 2018, 9:20 PM
This revision was automatically updated to reflect the committed changes.