Page MenuHomePhabricator

meson: follow up on neon build
AbandonedPublic

Authored by bu5hm4n on Nov 11 2018, 1:14 PM.

Details

Reviewers
raster
Summary

this implements the same things in a more 'meson' like way, headers are
checked in the header_checks file. The options are now a little bit
easier and more inline with how efl options are working. As an example,
you have -Dopengl=[none,full,egl-es]. Now you can also just enable the
architechture native optimization or not, undependend from the cpu
family or not.
Additionally, when a argument is used only in evas, the argument is
evalulated there.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7991
bu5hm4n created this revision.Nov 11 2018, 1:14 PM
bu5hm4n requested review of this revision.Nov 11 2018, 1:14 PM

@raster this does not add anything new, but it solves things in a more meson style way, (not maintaining variables by hand, adding things to the global arguments instead of mainting them by hand and adding them by hand.

Additionally, host_machine was wrong IMO, it should be target_machine. Additionally it appears that you could turn off the options, but the headers are checked anyways, and you will have a error, probebly not what we want.

It appears to work on my x86 things, but i don't have power64 nor arm nor aarch64 architectures arround here, can you test on them ?

raster requested changes to this revision.Nov 11 2018, 1:45 PM

hmm this isn't quite right. -msse3 should onlt be applied to the op_blend_master_sse3.c file build so the rest of efl doesn't build with sse3 optimizations in it and sse3 is only applied to this file which is runtime enabled by the sse3 detection. otherwise all of efl is built with sse3 asm optimizations and thus can't run on any cpu not supporting sse3 at all. :)

This revision now requires changes to proceed.Nov 11 2018, 1:45 PM
bu5hm4n abandoned this revision.Nov 23 2018, 1:55 AM