Page MenuHomePhabricator

eo: Avoid namespace clashes.
ClosedPublic

Authored by lauromoura on Nov 12 2018, 2:57 AM.

Details

Summary

This commit removes some clashes (i.e. names as classes and namespaces
at the same time). It'll avoid nested items that are either forbidden
(C#) or problematic (Python) in some languages.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Nov 12 2018, 2:57 AM
lauromoura requested review of this revision.Nov 12 2018, 2:57 AM
segfaultxavi accepted this revision.Nov 12 2018, 4:24 AM

Do you have any idea why these have not been detected until now? I thought eolian was enforcing this check :/

This revision is now accepted and ready to land.Nov 12 2018, 4:24 AM

Do you have any idea why these have not been detected until now? I thought eolian was enforcing this check :/

Maybe it checks for collisions among actually generated things (members, classes, events, etc) but not namespaces.

segfaultxavi requested changes to this revision.Nov 12 2018, 8:57 AM

Does not build for me:

bindings/mono/efl_mono/efl_all.cs(73,55): error CS0234: The type or namespace name `policy' does not exist in the namespace `elm'. Are you missing an assembly reference?

I had to change elm.policy.Quit.Last_window_hidden to elm.Policy_Quit.Last_window_hidden.

This revision now requires changes to proceed.Nov 12 2018, 8:57 AM

Update C# code after Xavi's comments.

Tested only the C/C++ code before submitting. Sorry.

segfaultxavi accepted this revision.Nov 13 2018, 12:48 AM

Step by step we are beating the Interfaces into shape, good job :)

This revision is now accepted and ready to land.Nov 13 2018, 12:48 AM
This revision was automatically updated to reflect the committed changes.

q66: ideas why this was not discovered ?