Page MenuHomePhabricator

GUI: add text setting
ClosedPublic

Authored by bowonryu on Nov 22 2018, 3:47 AM.

Details

Reviewers
JackDanielZ
Summary

The text setting shows your local font list.
This is stored in config, and this value applies to text of ea_gen.

Test Plan

ea_gen -> go to text setting

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8170
Build 7486: arc lint + arc unit
bowonryu requested review of this revision.Nov 22 2018, 3:47 AM
bowonryu created this revision.

Hi Bowon,

Thanks for this patch. It can be pushed soon, after the things related to the comments and some little issue are solved. When I run it and play with the spinner by moving with the mouse, it seems working, but when I move the spinner after the value 128, it comes back to 1. Weird no? I would have expected it to stop at this value

src/bin/gui.c
925

Why don't you use eina_strbuf_prepend_printf?

1296

same

1851

same

1958

unused variable: event

1979

_printf...

You can even use eina_strbuf_append_printf(sbuf, "font...%s%s...%s", ...font_name, _font_sample_str_get());

1989

unused variable: event

2010

unused variable: event_info

2030

btn set but not used

2097

Do you try to display fonts only once? Does it mean that the fonts are for sure sorted?

2152–2156

btn_text set but not used

src/bin/main.c
86

unused variable

87

same

bowonryu updated this revision to Diff 17545.Nov 22 2018, 7:02 PM

Hi, thanks to your comment,
I modified the code to fit the comments.

bowonryu updated this revision to Diff 17546.Nov 22 2018, 8:54 PM

fix some detail of theme

JackDanielZ accepted this revision.Nov 24 2018, 11:19 AM
This revision is now accepted and ready to land.Nov 24 2018, 11:19 AM
JackDanielZ closed this revision.Nov 24 2018, 11:19 AM