Differential D7332

elementary: make Efl.Ui.Factory.create asynchronous.
ClosedPublic
Actions

Authored by cedric on Nov 22 2018, 4:27 PM.

Tags

Subscribers

segfaultxavi, reviewers, committers

Details

Reviewers

felipealmeida
SanghyeonLee
vitor.sousa
bu5hm4n
segfaultxavi

Maniphest Tasks

T7472: Asynchronous create function in Efl.Ui.Factory

Commits

rEFL4d6f20d714ea: elementary: make Efl.Ui.Factory.create asynchronous.

Diff Detail

Repository

Branch

T7472-devs/cedric/async_factory

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8343

cedric created this revision.Nov 22 2018, 4:27 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptNov 22 2018, 4:27 PM

cedric requested review of this revision.Nov 22 2018, 4:27 PM

Harbormaster completed remote builds in B8142: Diff 17516.Nov 22 2018, 4:27 PM

SanghyeonLee mentioned this in T7472: Asynchronous create function in Efl.Ui.Factory.Nov 26 2018, 3:12 AM

cedric added a child revision: D7379: eo: make efl_future_then have a data pointer in addition of the object pointer..Nov 28 2018, 9:38 AM

Harbormaster completed remote builds in B8250: Diff 17654.Nov 28 2018, 9:39 AM

vitor.sousa accepted this revision.Nov 29 2018, 7:40 AM

This revision is now accepted and ready to land.Nov 29 2018, 7:40 AM

felipealmeida accepted this revision.Nov 29 2018, 9:49 AM

No change.

Harbormaster completed remote builds in B8282: Diff 17692.Nov 29 2018, 3:09 PM

segfaultxavi mentioned this in D7391: ecore: add efl_app_test to the meson build and run the test..Dec 3 2018, 2:02 AM

Rebase.

Harbormaster completed remote builds in B8343: Diff 17782.Dec 5 2018, 11:34 AM

Nothing.

Harbormaster completed remote builds in B8351: Diff 17790.Dec 5 2018, 12:13 PM

bu5hm4n mentioned this in D7381: ecore: use efl_future_then to simplify the code logic and reduce potential bugs..Dec 6 2018, 1:55 AM

This patch does not compile ... :(

This revision now requires changes to proceed.Dec 6 2018, 2:03 AM

segfaultxavi mentioned this in D7379: eo: make efl_future_then have a data pointer in addition of the object pointer..Dec 6 2018, 3:55 AM

Fix after rebase. Sorry for the break, rebase is not magical.

Harbormaster completed remote builds in B8368: Diff 17818.Dec 6 2018, 9:39 AM

ninja and ninja test work again and the patch has been already approved. Landing.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2018, 2:47 AM

Closed by commit rEFL4d6f20d714ea: elementary: make Efl.Ui.Factory.create asynchronous. (authored by cedric, committed by segfaultxavi). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
~			src/lib/efl/interfaces/efl_ui_factory.eo (2 lines)
~			src/lib/elementary/efl_ui_image_factory.c (9 lines)
~			src/lib/elementary/efl_ui_layout.c (145 lines)
~			src/lib/elementary/efl_ui_layout_factory.c (11 lines)
~			src/lib/elementary/efl_ui_list_view.c (69 lines)
~			src/lib/elementary/efl_ui_list_view_seg_array.h (2 lines)
~			src/lib/elementary/efl_ui_list_view_types.eot (1 line)

Diff 17782

src/lib/efl/interfaces/efl_ui_factory.eo

Loading...

src/lib/elementary/efl_ui_image_factory.c

Loading...

src/lib/elementary/efl_ui_layout.c

Loading...

src/lib/elementary/efl_ui_layout_factory.c

Loading...

src/lib/elementary/efl_ui_list_view.c

Loading...

src/lib/elementary/efl_ui_list_view_seg_array.h

Loading...

src/lib/elementary/efl_ui_list_view_types.eot

Loading...