Page MenuHomePhabricator
Differential D7380

ecore: remove unecessary intermediate variable.
ClosedPublic
Actions

Authored by cedric on Nov 28 2018, 9:38 AM.

Details

Reviewers
felipealmeida
segfaultxavi
vitor.sousa
SanghyeonLee
bu5hm4n
Maniphest Tasks
T7472: Asynchronous create function in Efl.Ui.Factory
Commits
rEFL436c5b85232a: ecore: remove unecessary intermediate variable.
Summary

Depends on D7379

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Nov 28 2018, 9:38 AM
Herald added subscribers: committers, reviewers. · View Herald TranscriptNov 28 2018, 9:38 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

segfaultxavi accepted this revision.Nov 29 2018, 1:45 AM
This revision is now accepted and ready to land.Nov 29 2018, 1:45 AM
cedric updated this revision to Diff 17694.Nov 29 2018, 3:10 PM
cedric added a reviewer: bu5hm4n.

No change.

cedric updated this revision to Diff 17784.Dec 5 2018, 11:35 AM

Rebase.

cedric updated this revision to Diff 17792.Dec 5 2018, 12:14 PM

Nothing.

segfaultxavi added a comment.Dec 6 2018, 1:11 AM

After a week being approved, I think you can legally land the patch yourself if the reviewer forgot.
Damn, one more week and you can legally marry the task and her parents cannot oppose :D

vitor.sousa accepted this revision.Dec 6 2018, 5:20 AM
cedric updated this revision to Diff 17820.Dec 6 2018, 9:39 AM

Nothing.

Closed by commit rEFL436c5b85232a: ecore: remove unecessary intermediate variable. (authored by cedric, committed by segfaultxavi). · Explain WhyDec 7 2018, 3:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/ecore/efl_exe.c (3 lines)

Diff 17836

View Options

src/lib/ecore/efl_exe.c

Loading...