Depends on D7380
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Branch
- T7472-devs/cedric/async_factory
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 8253
Comment Actions
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
Comment Actions
I am a bit confused. I was under the impression that efl_promise_* and efl_future_* methods had to be replaced by eina_promise_* and eina_future_*. Moreover, you seem to be mixing them (efl_future_then() accepts an Eina_promise).
Can you clarify the situation?
Comment Actions
Sure. So the old efl_promise* and efl_future* is dead. But along with eina_future_* being introduced, @barbieri introduced an efl_future_Eina_FutureXXX_then that linked the lifecycle of a future with the lifecycle of an object. That function was supposed to be renamed as soon as we got completely read of the old future, ..., which wasn't done until this serie of patch.
Comment Actions
It looks to me like we still have two sets of Promise methods, EFL's and EINA's. What is the relationship between efl_future_then() and eina_future_then(), for example?
Comment Actions
Also, I cannot apply this patch on top of latest master:
error: patch failed: src/lib/ecore/efl_model_composite_selection.c:262
Comment Actions
It looks right from reading it - however, i cannot build this as D7332 does not build
| src/lib/ecore/efl_model_composite_boolean.c | ||
|---|---|---|
| 192 | Why is that check not required anymore ? | |
| src/lib/ecore/efl_model_composite_selection.c | ||
| 220–221 | On a unrelated note, can you seperate functional changes from formatting ? It is a bit distracting when reviewing :) (Just a site note :)) | |
Comment Actions
Okay, i dropped the problem patch. However, eio test suite times out *sometimes*.
Its like running ninja test 10 times, 1 of the runs will not be successfull.
Comment Actions
Okay - timeout seems also to happen from time to time with master ... :(
With my comments answered this looks good
| src/lib/ecore/efl_model_composite_boolean.c | ||
|---|---|---|
| 192 | With efl_future_then you can specify the type of the value that is considered a success removing the need to do that check yourself. If the type is incorrect, efl_future_then will dispatch an error instead of the value itself. This help simplify the code. On the same remark, error with efl_future_then are also always dispatched to the error callback and if no handler for it is provided it will just continue down the chain. If you don't need to handle the error, no need to deal with it either. | |