Page MenuHomePhabricator

eolian-cxx: Add property_def
ClosedPublic

Authored by lauromoura on Nov 29 2018, 12:25 PM.

Details

Summary

While individual getters and setters are added to the list of methods of
a class, property_def will hold them as a pair.

This will help defining accessors like C#'s where they're grouped.

Also update some eolian-cxx tests that were commented out.

Depends: D7262

Test Plan

run eolian-cxx tests

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Nov 29 2018, 12:25 PM
lauromoura requested review of this revision.Nov 29 2018, 12:25 PM
vitor.sousa requested changes to this revision.Nov 30 2018, 10:30 AM

Very nice.
I have just some comments about indentation and names:

src/lib/eolian_cxx/grammar/klass_def.hpp
827

This one is indented using three spaces, but the operators above use only two.

1048

Missing indentation.

src/tests/eolian_cxx/properties.eo
1 ↗(On Diff #17689)

This name seems kind of strange to me, since this class is not really a property. Maybe something more in the line of the other test classes, like Dummy.PropertyHolder, PropertyDefiner, PropertyCollection, etc?

This revision now requires changes to proceed.Nov 30 2018, 10:30 AM
vitor.sousa added inline comments.Nov 30 2018, 10:35 AM
src/lib/eolian_cxx/grammar/klass_def.hpp
1082

oh, I forgot this one. It is indented with four spaces instead two.

lauromoura updated this revision to Diff 17710.Nov 30 2018, 1:14 PM

Update after Vitor comments. Changed properties.eo to property_holder.eo

vitor.sousa accepted this revision.Nov 30 2018, 1:22 PM
This revision is now accepted and ready to land.Nov 30 2018, 1:22 PM
This revision was automatically updated to reflect the committed changes.