Page MenuHomePhabricator

elm_config: repair configs
ClosedPublic

Authored by bu5hm4n on Dec 3 2018, 2:05 AM.

Details

Summary

in eec7bc458eee333fd7237a3bd43e8c2c884f21ca the epoch offset was edited,
which seems to be wrong, as this caused every single config to be
deleted. This also updates the configs in the elementry base configs
as they have been forgotten.

This brings back the ability to edit the config in elementary_config.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Dec 3 2018, 2:05 AM
bu5hm4n requested review of this revision.Dec 3 2018, 2:05 AM

I confirm this fixes elementary_config not being able to store any config for me.

So @devilhorns should have modified config_version instead of ELM_CONFIG_VERSION_EPOCH_OFFSET to avoid wiping out all config files? Then this fix makes sense to me.

Still, I would like to hear his opinion, since I am not familiar with Elm config files.
(@devilhorns will be held responsible for any damage caused to any user's config files in the meantime ๐Ÿ˜„)

raster accepted this revision.Dec 3 2018, 3:43 AM
This revision is now accepted and ready to land.Dec 3 2018, 3:43 AM
Closed by commit rEFL7f9cb37ea0f9: elm_config: repair configs (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by raster). ยท Explain WhyDec 3 2018, 3:47 AM
This revision was automatically updated to reflect the committed changes.