Details

Reviewers

jpeg
Hermet
Jaehyun_Cho
raster
barbieri

Maniphest Tasks

T3912: Box align : does not align if children set max hint

Commits

rEFL78ae9c0ae069: gfx: Add size hint fill (EO)

Summary

If widget use both hint_align(HINT_FILL) and hint_max together, there is no way
to set to hint_align. See, elementary_test -to 'efl.ui.box' -
"Button with a quite long text." button. you can control button position
using "Box align" slider, but this is not proper implementation. When there are
two widget which have hint_align(HINT_FILL) and hint_max, those positions are
determined by box_align rather than hint_align. it means widget align cannot be
set individually.
To solve this problem, this patch add hint_fill property. in order to avoid
conflict with legacy API named evas_object_size_hint_fill_set(), it only works
for EO widgets(made by efl_add).
Also, EFL_GFX_SIZE_HINT_FILL is removed.

@feature

Test Plan

elementary_test -to 'efl.ui.box'
elementary_test -to 'efl.ui.table'

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

YOhoho created this revision.Dec 3 2018, 11:51 PM

Herald added a project: efl. · View Herald TranscriptDec 3 2018, 11:51 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

YOhoho requested review of this revision.Dec 3 2018, 11:51 PM

Harbormaster completed remote builds in B8316: Diff 17749.Dec 3 2018, 11:51 PM

update docs.

Harbormaster completed remote builds in B8317: Diff 17750.Dec 3 2018, 11:53 PM

YOhoho added a child revision: D7463: test/ui_box: add unittest for Efl.Ui.Box.Dec 16 2018, 5:47 PM

YOhoho mentioned this in T5487: edje & elm sizing: respect hints & simplify layout api.Dec 16 2018, 5:49 PM

@YOhoho

"EFL_GFX_SIZE_HINT_FILL" with "hint_align_set" still exists in code.

Please check the above by searching as follows.

grep -nrI "EFL_GFX_SIZE_HINT_FILL" .
grep -nrI "hint_align_set(" . | grep "\-1" | grep -v "evas_object_size_hint_align_set("

This revision now requires changes to proceed.Dec 18 2018, 3:28 AM

YOhoho added a child revision: D7524: efl_ui_relative_layout: introduce new relative container.Dec 28 2018, 12:11 AM

Fix wrong usecase.

There are some case that legacy widgets use "HINT_FILL(-1)" with "efl_gfx_size_hint_align_set". that cases won't be fixed.

Harbormaster completed remote builds in B8689: Diff 18250.Jan 6 2019, 8:21 PM

Fix typo.

Harbormaster completed remote builds in B8690: Diff 18251.Jan 6 2019, 8:27 PM

@YOhoho
Could you please check the comments?

src/lib/elementary/efl_ui_box.c
128	did you simply remove this line because fill_set(1, 1) is called in evas_object_main.c?
src/lib/evas/canvas/evas_object_main.c
1837	Is there any reason why obj->legacy.finzlied here? If the conditional expression here, then error log is not displayed. e.g. Eo *btn = efl_add(...); efl_gfx_size_hint_align_set(btn, -1, -1);
1940	Is there any reason why obj->legacy.finzlied here?

YOhoho added inline comments.Jan 15 2019, 12:09 AM

src/lib/elementary/efl_ui_box.c
128	Yes, fill_set(1,1) is default values.
src/lib/evas/canvas/evas_object_main.c
1837	My fault. this condition will be removed. It means align_set allow to set negative values which might be 0 in a container except for -1. in order to avoid confusion of developer who is accustomed to legacy API(HINT_FILL), I'd like to keep -1 as special value implicitly. the special value(-1) is handled in a container.
1940	This is needless condition..

Remove needless condition and handle -1 value.

Harbormaster completed remote builds in B8808: Diff 18412.Jan 15 2019, 12:12 AM

zmike added a task: T3912: Box align : does not align if children set max hint.Jan 15 2019, 10:48 AM

zmike mentioned this in T3912: Box align : does not align if children set max hint.

@YOhoho
Thank you for the patch and updates! It is nice :)

This revision is now accepted and ready to land.Jan 15 2019, 11:44 PM

Closed by commit rEFL78ae9c0ae069: gfx: Add size hint fill (EO) (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by Jaehyun_Cho). · Explain WhyJan 16 2019, 12:18 AM

This revision was automatically updated to reflect the committed changes.

YOhoho removed a child revision: D7463: test/ui_box: add unittest for Efl.Ui.Box.Jan 24 2019, 1:36 AM

			Path	Packages
M			src/bin/elementary/test_bg.c (4 lines)
M			src/bin/elementary/test_evas_snapshot.c (2 lines)
M			src/bin/elementary/test_gfx_filters.c (11 lines)
M			src/bin/elementary/test_ui_box.c (132 lines)
M			src/bin/elementary/test_ui_clock.c (11 lines)
M			src/bin/elementary/test_ui_scroller.c (11 lines)
M			src/bin/elementary/test_ui_tab_pager.c (4 lines)
M			src/bin/elementary/test_ui_table.c (140 lines)
M			src/bin/elementary/test_ui_textpath.c (12 lines)
M			src/examples/elementary/button_cxx_example_01.cc (12 lines)
M			src/examples/elementary/calendar_cxx_example_04.cc (2 lines)
M			src/examples/elementary/efl_ui_grid_example_1.c (4 lines)
M			src/examples/elementary/efl_ui_list_example_1.c (4 lines)
M			src/examples/elementary/slider_cxx_example.cc (14 lines)
M			src/examples/elementary/spinner_cxx_example.cc (14 lines)
M			src/examples/elementary/toolbar_cxx_example_01.cc (5 lines)
M			src/lib/efl/interfaces/efl_gfx_size_hint.eo (44 lines)
M			src/lib/elementary/efl_ui_box.c (3 lines)
M			src/lib/elementary/efl_ui_box_layout.c (74 lines)
M			src/lib/elementary/efl_ui_list_view_precise_layouter.c (27 lines)
M			src/lib/elementary/efl_ui_scroll_alert_popup.c (2 lines)
M			src/lib/elementary/efl_ui_tags.c (16 lines)
M			src/lib/elementary/efl_ui_win.c (2 lines)
M			src/lib/elementary/elm_colorselector.c (2 lines)
M			src/lib/evas/canvas/efl_canvas_object.eo (1 line)
M			src/lib/evas/canvas/evas_object_main.c (55 lines)
M			src/lib/evas/canvas/evas_object_table.c (7 lines)
M			src/lib/evas/include/evas_private.h (8 lines)
M			src/tests/elementary/efl_ui_test_grid.c (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17749	48ca7a2		Dec 3 2018, 11:51 PM	★	★
Diff 2	17750	48ca7a2	update docs.	Dec 3 2018, 11:53 PM	★	★
Diff 3	18250	efd0efb	Fix wrong usecase.	Jan 6 2019, 8:21 PM	★	★
Diff 4	18251	efd0efb	Fix typo.	Jan 6 2019, 8:27 PM	★	★
Diff 5	18412	130fe0b	Remove needless condition and handle -1 value.	Jan 15 2019, 12:11 AM	★	★
Diff 6	18451	4858d9e	rEFL78ae9c0ae069ff86e701ff98cf5674cc491ee156	Jan 15 2019, 11:47 PM	★	★

	Status	Author	Revision
	Closed	YOhoho	D7524 efl_ui_relative_layout: introduce new relative container
	Closed	YOhoho	D7409 gfx: Add size hint fill (EO)

gfx: Add size hint fill (EO)
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 18451

src/bin/elementary/test_bg.c

src/bin/elementary/test_evas_snapshot.c

src/bin/elementary/test_gfx_filters.c

src/bin/elementary/test_ui_box.c

src/bin/elementary/test_ui_clock.c

src/bin/elementary/test_ui_scroller.c

src/bin/elementary/test_ui_tab_pager.c

src/bin/elementary/test_ui_table.c

src/bin/elementary/test_ui_textpath.c

src/examples/elementary/button_cxx_example_01.cc

src/examples/elementary/calendar_cxx_example_04.cc

src/examples/elementary/efl_ui_grid_example_1.c

src/examples/elementary/efl_ui_list_example_1.c

src/examples/elementary/slider_cxx_example.cc

src/examples/elementary/spinner_cxx_example.cc

src/examples/elementary/toolbar_cxx_example_01.cc

src/lib/efl/interfaces/efl_gfx_size_hint.eo

src/lib/elementary/efl_ui_box.c

src/lib/elementary/efl_ui_box_layout.c

src/lib/elementary/efl_ui_list_view_precise_layouter.c

src/lib/elementary/efl_ui_scroll_alert_popup.c

src/lib/elementary/efl_ui_tags.c

src/lib/elementary/efl_ui_win.c

src/lib/elementary/elm_colorselector.c

src/lib/evas/canvas/efl_canvas_object.eo

src/lib/evas/canvas/evas_object_main.c

src/lib/evas/canvas/evas_object_table.c

src/lib/evas/include/evas_private.h

src/tests/elementary/efl_ui_test_grid.c

gfx: Add size hint fill (EO)ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 18451

src/bin/elementary/test_bg.c

src/bin/elementary/test_evas_snapshot.c

src/bin/elementary/test_gfx_filters.c

src/bin/elementary/test_ui_box.c

src/bin/elementary/test_ui_clock.c

src/bin/elementary/test_ui_scroller.c

src/bin/elementary/test_ui_tab_pager.c

src/bin/elementary/test_ui_table.c

src/bin/elementary/test_ui_textpath.c

src/examples/elementary/button_cxx_example_01.cc

src/examples/elementary/calendar_cxx_example_04.cc

src/examples/elementary/efl_ui_grid_example_1.c

src/examples/elementary/efl_ui_list_example_1.c

src/examples/elementary/slider_cxx_example.cc

src/examples/elementary/spinner_cxx_example.cc

src/examples/elementary/toolbar_cxx_example_01.cc

src/lib/efl/interfaces/efl_gfx_size_hint.eo

src/lib/elementary/efl_ui_box.c

src/lib/elementary/efl_ui_box_layout.c

src/lib/elementary/efl_ui_list_view_precise_layouter.c

src/lib/elementary/efl_ui_scroll_alert_popup.c

src/lib/elementary/efl_ui_tags.c

src/lib/elementary/efl_ui_win.c

src/lib/elementary/elm_colorselector.c

src/lib/evas/canvas/efl_canvas_object.eo

src/lib/evas/canvas/evas_object_main.c

src/lib/evas/canvas/evas_object_table.c

src/lib/evas/include/evas_private.h

src/tests/elementary/efl_ui_test_grid.c

gfx: Add size hint fill (EO)
ClosedPublic
Actions

Revision Contents
Changeset List