Page MenuHomePhabricator

eio-tests: fix deadlocking of the testsuite
ClosedPublic

Authored by bu5hm4n on Dec 4 2018, 7:19 AM.

Details

Summary

what happens was is that efl_model_children_count_get trigger the
monitoring to start. However, that means that *sometimes* the created
file in this test was sometimes called in a ADDED event due to the
listing of files, and sometimes due to the event of a newly added file.
The problem here is that when the ADDED event is added due to the file
listing and not the monitoring, then there *could* be a ADDED event and
the deletion of the file will not trigger a REMOVED event. Which is a
bug.

However, up to this point it is not fully clear to me if this is
solvable with this setup of monitoring or not. So this test is changed
to not trigger this deadlock anymore, the idea of the test is still
tested, just in another way.

ref T7478

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Dec 4 2018, 7:19 AM
bu5hm4n requested review of this revision.Dec 4 2018, 7:19 AM
netstar accepted this revision.Dec 4 2018, 7:52 AM
netstar added a subscriber: netstar.

Looks okay. Could check temp_filename for NULL ?

This revision is now accepted and ready to land.Dec 4 2018, 7:52 AM

Not sure if it makes a difference ... :) temp_filename is automatically initializated with started_up beeing false.

Closed by commit rEFL117d94d90ebb: eio-tests: fix deadlocking of the testsuite (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyDec 20 2018, 5:07 AM
This revision was automatically updated to reflect the committed changes.